Skip to content
This repository was archived by the owner on Jan 14, 2025. It is now read-only.

Conversation

@lrhn
Copy link
Contributor

@lrhn lrhn commented Mar 11, 2020

Implementation of dart-lang/language#863

Some clean-up.

@jakemac53
Copy link
Contributor

Do we know that flutter/fuschia always use the .packages file name? What about google3?

@lrhn
Copy link
Contributor Author

lrhn commented Mar 11, 2020

If they don't use the default name that Pub uses, then they probably also don't use the default Pub layout. This code optimizes for the common case where Pub has generated a .packages and a .dart_tool/package_config.json file and someone points to the .packages file. We then guess the location of the package_config.json file, but that only makes sense in that particular case.

All other cases need to point to the package_config.json file directly if they want to load it. We can't help them otherwise.

@lrhn lrhn merged commit c3301f6 into master Mar 12, 2020
@kevmoo kevmoo deleted the update-dotpackages-lookup branch July 11, 2021 04:00
mosuem pushed a commit to dart-lang/tools that referenced this pull request Dec 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Development

Successfully merging this pull request may close these issues.

5 participants