Repository navigation
Conversation
clang 11 silently dropped -msse/-msse2/-msse3 when targeting aarch64; clang 19 errors on them. Wrap the SSE compile flags in TARGET_i386 / TARGET_x86_64 guards so Darling builds cleanly under any clang. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Member
|
Thank you for this work. The changes in this PR are now present in the revision of this repository that darling master pins (the arm64 support was integrated through darlinghq/darling#1818), so I am closing it as superseded. Please reopen if you see anything here that is still missing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clang 11 silently dropped
-msse/-msse2/-msse3when targeting aarch64; clang 16+ errors on them. Wrap the SSE compile flags insideTARGET_i386 OR TARGET_x86_64so Darling builds cleanly on aarch64 hosts regardless of which clang is in use. No behavior change on x86 builds.Part of the ARM64 support series.