Skip to content

Conversation

@clowa
Copy link

@clowa clowa commented Oct 9, 2024

This pull request includes several changes to resource suffixes to match the suggested resource abbreviations of the Azure Cloud Adoption Framework. This could be beneficial for this module since most of the customers follow these recommendations to have a consistent naming.

Compliance with Naming Conventions:

  • bastion.tf: Adjusted the names of the bastion host and bastion public IP resources.
    (azurerm_public_ip.bastion_public_ip, azurerm_bastion_host.bastion)

  • locals.tf: Adjusted the names of the load balancer and data collection rule.
    (local.lb_name, local.data_collection_name)

  • logging.tf: Adjusted the data collection rule and its association names as well as the log analytics workspace.
    (azurerm_monitor_data_collection_rule.vsensor_data_collection, azurerm_monitor_data_collection_rule_association.vsensor_data_collection_assoc, azurerm_log_analytics_workspace.vsensor_logs)

  • network.tf: Adjusted the names of the NAT gateway and NAT gateway public IP resources.
    (azurerm_public_ip.natgw_public_ip, azurerm_nat_gateway.natgw)

  • pcaps.tf: Adjusted the name of the service endpoint policy resource.
    (azurerm_subnet_service_endpoint_storage_policy.pcaps_service_endpoint_policy)

  • private_link.tf: Adjusted the name of the private link service resource. (azurerm_private_link_service.ossensor_private_link)

Minor Cleanups:

  • main.tf: Simplified the azurerm_subscription data block.
    (data.azurerm_subscription.subscription)

  • pcaps.tf: Simplified the random_uuid resource block.
    (random_uuid.pcap_uuid)

@clowa clowa marked this pull request as ready for review October 9, 2024 12:46
@clowa
Copy link
Author

clowa commented Oct 10, 2024

Hi @mstratford-dt, just want to reach of if you see any value in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant