Fix filmstrip double marker issue (#19772) #19777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The filmstrip current-image marker (black arrow) was appearing on multiple thumbnails spaced by the number of visible items in the filmstrip. This occurred because the w_cursor widget visibility was tied only to thumb->active flag, which could be set on multiple thumbnails during scrolling and thumbnail reuse. The fix adds a double-check in _thumb_update_icons() to ensure the cursor arrow is shown only when both conditions are met: - thumb->active is TRUE - thumb->imgid matches the first entry in active_images list This ensures only the actual current/active image displays the marker, eliminating visual confusion between selection highlight and current-image indicator. Fixes darktable-org#19772
TurboGit
added
bugfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The filmstrip current-image marker (black arrow) was appearing on multiple thumbnails spaced by the number of visible items in the filmstrip. This occurred because the w_cursor widget visibility was tied only to thumb->active flag, which could be set on multiple thumbnails during scrolling and thumbnail reuse.
The fix adds a double-check in _thumb_update_icons() to ensure the cursor arrow is shown only when both conditions are met:
This ensures only the actual current/active image displays the marker, eliminating visual confusion between selection highlight and current-image indicator.
Fixes #19772