agx: Remove migration of test (pre-7) versions

[kofa73]

We don't want to maintain the migration code for the 6 test versions made before darktable 5.4 is officially released with AgX. In order to avoid crashes, we'll simply overwrite old versions with whatever the defaults of the currently latest version of darktable are.
Since this is a special case (sorry for breaking the rules -- I never thought it would get so badly out of hand), there are some repeated, screaming comments regarding the SPECIAL CASE. :-/

Announcement on pixls

In draft for a few days, so users can migrate their images before this gets released with a nightly. This comment will be removed when the PR is taken out of draft.

[kofa73]

I'll check the failures later this week.
update: It's some preprocessor magic. This fails:

#define AGX_VERSION 7

DT_MODULE_INTROSPECTION(AGX_VERSION, dt_iop_agx_params_t)

This works:

#define AGX_VERSION 7

DT_MODULE_INTROSPECTION(7, dt_iop_agx_params_t)

Would that be an acceptable replacement?

*new_version = self->so->get_introspection()->params_version;

[TurboGit]

@kofa73 : No keep the current code, looking at the diff in GitHub was misleading it is clear now with your comments here. With some comments on the code too it would be just good. Thanks.

[TurboGit]

Ah indeed missed that, DT_MODULE_INTROSPECTION needs a value as it is a simple parsing with a perl script.

So yes, I would do:

DT_MODULE_INTROSPECTION(7, dt_iop_agx_params_t)

And

*new_version = self->so->version();

And just remove AGX_VERSION as not needed.

[horazont]

Uhhh…

I made a bunch of styles based on v6 over the past weeks. Is there a way to upgrade styles, too?

EDIT: just found the answer ("No") in the pixls thread.

[kofa73]

Let's wait with merging this until next Monday, so people have time to migrate their images.

[TurboGit]

I'll merge this tomorrow morning (Nov 24) around 8h CET.

[kofa73]

Thank you!