Cached process.env.NODE_ENV access for performance #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@rijuma is attempting to deploy a commit to the darkroom Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
Removed due to lack of interest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just adding my two cents on this amazing project. Accessing env variables with
process.envvariables impacts on performance (read github issue), as it involves a C-level lookup that can be slower than accessing a regular JavaScript variable.Assigning it to a variable and exporting it makes it lookup only once. It's just a NIT.
Additionally, a super nit is the change for using
className={isDev ? 'dev' : null}instead ofclassName={isDev && 'dev'}(returningnullinstead offalse) avoids an empty class attribute on the html tag.