Add quickstart for Conversation AI java sdk #1196
Open
+194
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: siri-varma <[email protected]>
|
@salaboy @cicoyle @artur-ciocanu Can you folks take a look at this PR please ? |
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: siri-varma <[email protected]>
|
@cicoyle Could you please approve the CI one more time ? I validated it locally. Should succeed now. |
Signed-off-by: Siri Varma Vegiraju <[email protected]>
Signed-off-by: Siri Varma Vegiraju <[email protected]>
|
@siri-varma same.. from a pure Java standpoint this PR LGTM, ready to be merged! |
alicejgibbons
requested changes
May 28, 2025
| <dependency> | ||
| <groupId>io.dapr</groupId> | ||
| <artifactId>dapr-sdk</artifactId> | ||
| <version>1.15.0-rc-5</version> |
There was a problem hiding this comment.
Lets wait to merge this until were get the 1.15.0 real version (im told this week by @cicoyle )
conversation/java/sdk/conversation/src/main/java/com/service/ConversationAIApplication.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Alice Gibbons <[email protected]> Signed-off-by: Siri Varma Vegiraju <[email protected]>
Signed-off-by: siri-varma <[email protected]>
…-varma/quickstarts into users/svegiraju/quickstarts
alicejgibbons
requested changes
May 28, 2025
conversation/java/sdk/conversation/src/main/java/com/service/ConversationAIApplication.java
Outdated
Show resolved
Hide resolved
conversation/java/sdk/conversation/src/main/java/com/service/ConversationAIApplication.java
Outdated
Show resolved
Hide resolved
Signed-off-by: siri-varma <[email protected]>
|
Validated locally |
|
@alicejgibbons small request, could you please trigger the build for this PR ? Want to make sure it passes so that we will not have any surprises at the end |
|
Im honestly fine merging this and then once I cut the official java release we can come back and update the versions everywhere - that way this PR doesnt get blocked |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add quickstart for Conversation AI sdk
Issue reference
We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1155
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: