-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation API support #787
Conversation API support #787
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.15 #787 +/- ##
===============================================
Coverage ? 86.39%
===============================================
Files ? 89
Lines ? 5064
Branches ? 0
===============================================
Hits ? 4375
Misses ? 689
Partials ? 0 ☔ View full report in Codecov by Sentry. |
@@ -8,7 +8,9 @@ | |||
[](https://github.com/dapr/python-sdk/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22) | |||
[](http://bit.ly/dapr-discord) | |||
[](https://youtube.com/@daprdev) | |||
<!-- IGNORE_LINKS --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is needed because x.com profiles are not public anymore and return 403, making the Mechanical markdown validation fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added two suggestions for the PII scrubbing
Signed-off-by: Elena Kolevska <[email protected]>
Signed-off-by: Elena Kolevska <[email protected]>
Signed-off-by: Elena Kolevska <[email protected]>
Signed-off-by: Elena Kolevska <[email protected]>
Signed-off-by: Elena Kolevska <[email protected]>
Co-authored-by: Marc Duiker <[email protected]> Signed-off-by: Elena Kolevska <[email protected]>
Signed-off-by: Elena Kolevska <[email protected]>
036d9d8
to
a642176
Compare
Signed-off-by: Elena Kolevska <[email protected]>
a642176
to
9bf0e27
Compare
Signed-off-by: Elena Kolevska <[email protected]>
e769371
to
9686dee
Compare
Description
Adds support for the Dapr Conversation API.
I suffixed the
converse
method name withalpha1
. This is open for discussion. We haven't been using the suffix in the python sdk, but we do it in Go. I believe it's safer to have it suffixed, but if we're reasonably certain the API won't break we can just useconverse
.Issue reference
#786
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: