Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation API support #787

Merged
merged 9 commits into from
Feb 24, 2025

Conversation

elena-kolevska
Copy link
Contributor

@elena-kolevska elena-kolevska commented Feb 24, 2025

Description

Adds support for the Dapr Conversation API.

I suffixed the converse method name with alpha1. This is open for discussion. We haven't been using the suffix in the python sdk, but we do it in Go. I believe it's safer to have it suffixed, but if we're reasonably certain the API won't break we can just use converse.

Issue reference

#786

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@elena-kolevska elena-kolevska changed the title Conversation API support (sync) Conversation API support Feb 24, 2025
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-1.15@ba64f31). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff               @@
##             release-1.15     #787   +/-   ##
===============================================
  Coverage                ?   86.39%           
===============================================
  Files                   ?       89           
  Lines                   ?     5064           
  Branches                ?        0           
===============================================
  Hits                    ?     4375           
  Misses                  ?      689           
  Partials                ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elena-kolevska elena-kolevska marked this pull request as ready for review February 24, 2025 11:46
@elena-kolevska elena-kolevska requested review from a team as code owners February 24, 2025 11:46
@@ -8,7 +8,9 @@
[![GitHub issue custom search in repo](https://img.shields.io/github/issues-search/dapr/python-sdk?query=type%3Aissue%20is%3Aopen%20label%3A%22good%20first%20issue%22&label=Good%20first%20issues&style=flat&logo=github)](https://github.com/dapr/python-sdk/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22)
[![Discord](https://img.shields.io/discord/778680217417809931?label=Discord&style=flat&logo=discord)](http://bit.ly/dapr-discord)
[![YouTube Channel Views](https://img.shields.io/youtube/channel/views/UCtpSQ9BLB_3EXdWAUQYwnRA?style=flat&label=YouTube%20views&logo=youtube)](https://youtube.com/@daprdev)
<!-- IGNORE_LINKS -->
Copy link
Contributor Author

@elena-kolevska elena-kolevska Feb 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed because x.com profiles are not public anymore and return 403, making the Mechanical markdown validation fail.

Copy link
Contributor

@marcduiker marcduiker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added two suggestions for the PII scrubbing

elena-kolevska and others added 7 commits February 24, 2025 18:21
Signed-off-by: Elena Kolevska <[email protected]>
Signed-off-by: Elena Kolevska <[email protected]>
Signed-off-by: Elena Kolevska <[email protected]>
Signed-off-by: Elena Kolevska <[email protected]>
Co-authored-by: Marc Duiker <[email protected]>
Signed-off-by: Elena Kolevska <[email protected]>
Signed-off-by: Elena Kolevska <[email protected]>
@elena-kolevska elena-kolevska changed the base branch from main to release-1.15 February 24, 2025 18:41
Signed-off-by: Elena Kolevska <[email protected]>
@elena-kolevska elena-kolevska added this to the v1.15 milestone Feb 24, 2025
@elena-kolevska elena-kolevska merged commit 6c3e40c into dapr:release-1.15 Feb 24, 2025
15 checks passed
@elena-kolevska elena-kolevska deleted the conversation-api branch February 24, 2025 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants