Skip to content

[WIP] Added docs for RavenDB as State Store #4600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: v1.15
Choose a base branch
from

Conversation

nmalocic
Copy link

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Added documentation for RavenDB state store.
Supported operations, and explanation to configuration.

Issue reference

Issue is in components-contrib repo

@nmalocic nmalocic requested review from a team as code owners March 26, 2025 12:05
@mikeee
Copy link
Member

mikeee commented Mar 26, 2025

nmalocic and others added 8 commits March 31, 2025 10:43
"Scop" fixed to "Scope"

Signed-off-by: James Pegg <[email protected]>
Signed-off-by: Nemanja Malocic <[email protected]>
* Update self-hosted-with-docker.md - make scheduler running

Signed-off-by: Mathieu Benoit <[email protected]>

* Update self-hosted-with-docker.md - --scheduler-host-address

Signed-off-by: Mathieu Benoit <[email protected]>

* Update self-hosted-with-docker.md - Use smaller container images for placement and scheduler

Signed-off-by: Mathieu Benoit <[email protected]>

---------

Signed-off-by: Mathieu Benoit <[email protected]>
Signed-off-by: Nemanja Malocic <[email protected]>
Signed-off-by: Nemanja Malocic <[email protected]>
Signed-off-by: Nemanja Malocic <[email protected]>
Update to .NET 8 runtime

Signed-off-by: Alice Gibbons <[email protected]>
Signed-off-by: Nemanja Malocic <[email protected]>
@nmalocic nmalocic force-pushed the 3318-ravendb-docs branch from ca79543 to 46a8c73 Compare March 31, 2025 11:49
command: ["./placement", "--port", "50006"]
ports:
- "50006:50006"

scheduler:
image: "daprio/dapr"
command: ["./scheduler", "--port", "50007"]
image: "daprio/scheduler"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nmalocic - thanks for the PR 🎉 I see there are extra changes beyond the scope of this PRs intentions. Mind removing the extra files - you might be able to run git restore or similar. If the diff still shows, feel free to close and open a new PR if that is easiest.

Copy link

github-actions bot commented Apr 8, 2025

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Apr 8, 2025
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments. However given this is in the v1.16 release, can you target the PR at the v1.16 docs branch (currently this is targeted at v1.15). Thanks

| EnableTTL | N | Boolean value to enable TTL capability. Defaults to `"true"` | `"true"`
| TTLFrequency | N | Additional parameters to use | `"5s"`

> <sup>[1]</sup> The `certPath` and `keyPath` fields are not mandatory if server url is http, however if server url is https and no certPath and keyPath is present dapr returns an error.
Copy link
Member

@msfussell msfussell Apr 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> <sup>[1]</sup> The `certPath` and `keyPath` fields are not mandatory if server url is http, however if server url is https and no certPath and keyPath is present dapr returns an error.
> <sup>[1]</sup> The `certPath` and `keyPath` fields are not mandatory if server url is `http`. However if the server url is `https` and no certPath and keyPath is present, then Dapr returns an error.

link: setup-ravendb
state: Stable
version: v1
since: "1.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
since: "1.0"
since: "1.16"

@msfussell msfussell added waiting-on-code-pr The code PR needs to be merged before the docs are updated and removed stale labels Apr 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-on-code-pr The code PR needs to be merged before the docs are updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants