fix: arguments accept units #1490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`max-body-size` and `read-buffer-size` now accept units as defined in the docs. Fixes dapr#1489 Signed-off-by: Mike Nguyen <[email protected]>
Signed-off-by: Mike Nguyen <[email protected]>
Signed-off-by: Mike Nguyen <[email protected]>
3 tasks
Signed-off-by: Mike Nguyen <[email protected]>
`max-body-size` is defaulted to 4Mi `request-buffer-size` is defaulted to 4Ki This is inline with the runtime. Signed-off-by: Mike Nguyen <[email protected]>
Signed-off-by: Mike Nguyen <[email protected]>
Signed-off-by: Mike Nguyen <[email protected]>
Co-authored-by: Anton Troshin <[email protected]> Signed-off-by: Mike Nguyen <[email protected]>
antontroshin
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
max-body-sizeandread-buffer-sizenow accept units as defined in the docs.Defaults of 4Mi and 4Ki respectively are also set
Fixes #1489
Description
Please explain the changes you've made
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: