Skip to content

DAOS-19005 test: Fix dfuse daos_build tests#18363

Draft
phender wants to merge 22 commits into
masterfrom
hendersp/DAOS-19005
Draft

DAOS-19005 test: Fix dfuse daos_build tests#18363
phender wants to merge 22 commits into
masterfrom
hendersp/DAOS-19005

Conversation

@phender
Copy link
Copy Markdown
Contributor

@phender phender commented May 26, 2026

Resolve issues installing elftools and hatchling for daos_build tests.

Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: DaosBuild DaosBuildVM

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

phender added 2 commits May 26, 2026 12:16
Resolve issues installing elftools and hatchling for daos_build tests.

Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: DaosBuild DaosBuildVM

Signed-off-by: Phil Henderson <phillip.henderson@hpe.com>
Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: DaosBuild DaosBuildVM

Signed-off-by: Phil Henderson <phillip.henderson@hpe.com>
Comment thread src/tests/ftest/dfuse/daos_build.py Outdated
Comment on lines +138 to +139
f'{sys.executable} -m pip install pip --upgrade',
f'{sys.executable} -m pip install -r {build_dir}/requirements-build.txt',
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if something got missed somewhere because above is

f'{sys.executable} -m venv {mount_dir}/venv'

And even higher is

remote_env['VIRTUAL_ENV'] = os.path.join(mount_dir, 'venv')

But it doesn't seem that we ever source that virtual env?
Maybe we should remove the venv and VIRTUAL_ENV stuff from this test now and just use sys.executable as you're doing

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 26, 2026

Ticket title is 'dfuse/daos_build_vm.py:DaosBuildVM.test_dfuse_daos_build_* - elftools / hatchling issues'
Status is 'In Progress'
Labels: 'ci_master_weekly,triaged,weekly_test'
https://daosio.atlassian.net/browse/DAOS-19005

@daosbuild3
Copy link
Copy Markdown
Collaborator

Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: DaosBuild DaosBuildVM

Signed-off-by: Phil Henderson <phillip.henderson@hpe.com>
@daosbuild3
Copy link
Copy Markdown
Collaborator

phender added 2 commits May 27, 2026 12:05
Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: DaosBuild DaosBuildVM

Signed-off-by: Phil Henderson <phillip.henderson@hpe.com>
Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: DaosBuild DaosBuildVM

Signed-off-by: Phil Henderson <phillip.henderson@hpe.com>
@daosbuild3
Copy link
Copy Markdown
Collaborator

@daosbuild3
Copy link
Copy Markdown
Collaborator

phender added 4 commits May 29, 2026 15:30
Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: DaosBuild DaosBuildVM

Signed-off-by: Phil Henderson <phillip.henderson@hpe.com>
Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: DaosBuild DaosBuildVM

Signed-off-by: Phil Henderson <phillip.henderson@hpe.com>
Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: DaosBuild DaosBuildVM

Signed-off-by: Phil Henderson <phillip.henderson@hpe.com>
@daosbuild3
Copy link
Copy Markdown
Collaborator

Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: DaosBuild DaosBuildVM

Signed-off-by: Phil Henderson <phillip.henderson@hpe.com>
@daosbuild3
Copy link
Copy Markdown
Collaborator

Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: DaosBuild DaosBuildVM

Signed-off-by: Phil Henderson <phillip.henderson@hpe.com>
@daosbuild3
Copy link
Copy Markdown
Collaborator

Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: DaosBuild DaosBuildVM

Signed-off-by: Phil Henderson <phillip.henderson@hpe.com>
@daosbuild3
Copy link
Copy Markdown
Collaborator

Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: DaosBuild DaosBuildVM

Signed-off-by: Phil Henderson <phillip.henderson@hpe.com>
@daosbuild3
Copy link
Copy Markdown
Collaborator

Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: DaosBuild DaosBuildVM

Signed-off-by: Phil Henderson <phillip.henderson@hpe.com>
@daosbuild3
Copy link
Copy Markdown
Collaborator

Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: DaosBuild DaosBuildVM

Signed-off-by: Phil Henderson <phillip.henderson@hpe.com>
@daosbuild3
Copy link
Copy Markdown
Collaborator

Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: DaosBuild DaosBuildVM

Signed-off-by: Phil Henderson <phillip.henderson@hpe.com>
@daosbuild3
Copy link
Copy Markdown
Collaborator

Comment thread src/tests/ftest/daos_build.sh Outdated
Comment on lines +24 to +32
echo " -p, --python_cmd <val> Python command to use (default: python3)"
echo " -v, --python_venv <val> Path to Python virtual environment (default: /tmp/daos_build/venv)"
echo " -b, --build_dir <val> Directory to clone and build DAOS (default: /tmp/daos_build/daos)"
echo " -g, --git_checkout <val> Git branch or commit to checkout (default: origin/master)"
echo " -d, --distro <val> Linux distribution for installing dependencies (default: el9)"
echo " -j, --build_jobs <val> Number of parallel jobs for building DAOS (default: 30)"
echo " -f, --filesystem_test Whether to run filesystem tests (default: false)"
echo " -r, --rebuild Whether to skip setup of build and venv directories (default: false)"
echo " -h, --help Show this help message and exit"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO it's better to use dashses instead of underscores in argument names because that is much more common practice

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 3d68316

Comment thread src/tests/ftest/daos_build.sh Outdated

# Create a Python virtual environment and install python build dependencies
if [ "${rebuild}" = "false" ]; then
run_cmd 1m "rm -rf ${python_venv}" || exit $?
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI you don't need the $? because that is piped through. So you could simplify to

Suggested change
run_cmd 1m "rm -rf ${python_venv}" || exit $?
run_cmd 1m "rm -rf ${python_venv}" || exit

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in c1933fe

Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: DaosBuild DaosBuildVM

Signed-off-by: Phil Henderson <phillip.henderson@hpe.com>
@daosbuild3
Copy link
Copy Markdown
Collaborator

Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: DaosBuild DaosBuildVM

Signed-off-by: Phil Henderson <phillip.henderson@hpe.com>
@daosbuild3
Copy link
Copy Markdown
Collaborator

Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-test-el8: false
Skip-func-test-leap15: false
Test-tag: DaosBuild DaosBuildVM

Signed-off-by: Phil Henderson <phillip.henderson@hpe.com>
@daosbuild3
Copy link
Copy Markdown
Collaborator

@daosbuild3
Copy link
Copy Markdown
Collaborator

@daosbuild3
Copy link
Copy Markdown
Collaborator

Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-test-el8: false
Skip-func-test-leap15: false
Test-tag: DaosBuild DaosBuildVM

Signed-off-by: Phil Henderson <phillip.henderson@hpe.com>
@daosbuild3
Copy link
Copy Markdown
Collaborator

@daosbuild3
Copy link
Copy Markdown
Collaborator

Test stage Functional on Leap 15 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-18363/21/testReport/

@daosbuild3
Copy link
Copy Markdown
Collaborator

Test stage Functional on SLES 15 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-18363/21/testReport/

@daosbuild3
Copy link
Copy Markdown
Collaborator

phender added 2 commits June 3, 2026 09:01
Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-test-el8: false
Skip-func-test-leap15: false
Test-tag: DaosBuild DaosBuildVM

Signed-off-by: Phil Henderson <phillip.henderson@hpe.com>
Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-test-el8: false
Skip-func-test-leap15: false
Test-tag: DaosBuild DaosBuildVM

Signed-off-by: Phil Henderson <phillip.henderson@hpe.com>
@daosbuild3
Copy link
Copy Markdown
Collaborator

Test stage Functional on SLES 15 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-18363/23/testReport/

@daosbuild3
Copy link
Copy Markdown
Collaborator

Test stage Functional on Leap 15 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-18363/23/testReport/

@daosbuild3
Copy link
Copy Markdown
Collaborator

@daosbuild3
Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants