DAOS-18866 vos: return nonexist error#18219
Open
NiuYawei wants to merge 2 commits into
Open
Conversation
vos_obj_incarnate() should return DER_NONEXIST error when CREATE flag isn't present. Signed-off-by: Niu Yawei <yawei.niu@hpe.com>
|
Ticket title is 'ior/hard.py:IorHardBasic.test_ior_hard - ior No space left on device' |
Nasf-Fan
previously approved these changes
May 12, 2026
Contributor
Nasf-Fan
left a comment
There was a problem hiding this comment.
The patch is fine. But I cannot understand why the original logic will cause PMEM trouble.
janekmi
previously approved these changes
May 12, 2026
Contributor
There was a problem hiding this comment.
This patch looks ok-ish but:
- This very odd such a bug won't cause a lot more serious issues.
- It is a little frightening we do not have a unit test covering this scenario.
- This does not solve the DAOS-18866 issue but something interesting has happened. For the first time I see one of the test cases actually PASSed. Till now either all of them have failed or all of them have PASSed. I will re-test to confirm this effect.
Return DER_NONEXIST error when object doesn't exist for unconditional punch. Signed-off-by: Niu Yawei <yawei.niu@hpe.com>
Contributor
Author
Thanks @janekmi . I guess it could be related to the unconditional punch changes. I updated to PR to return -DER_NONEXIST before starting tx when possible (which mimics the original behavior), could retry and see if it could fully solve the issue? Thanks in advance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vos_obj_incarnate() should return DER_NONEXIST error when CREATE flag isn't present.
Steps for the author:
After all prior steps are complete: