Skip to content

DAOS-18866 vos: return nonexist error#18219

Open
NiuYawei wants to merge 2 commits into
masterfrom
niu/DAOS-18866
Open

DAOS-18866 vos: return nonexist error#18219
NiuYawei wants to merge 2 commits into
masterfrom
niu/DAOS-18866

Conversation

@NiuYawei
Copy link
Copy Markdown
Contributor

vos_obj_incarnate() should return DER_NONEXIST error when CREATE flag isn't present.

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

vos_obj_incarnate() should return DER_NONEXIST error when CREATE
flag isn't present.

Signed-off-by: Niu Yawei <yawei.niu@hpe.com>
@NiuYawei NiuYawei requested review from a team as code owners May 12, 2026 07:26
@github-actions
Copy link
Copy Markdown

Ticket title is 'ior/hard.py:IorHardBasic.test_ior_hard - ior No space left on device'
Status is 'In Progress'
Labels: 'ci_master_weekly,ucx_provider,weekly_test'
https://daosio.atlassian.net/browse/DAOS-18866

@NiuYawei NiuYawei requested review from Nasf-Fan and janekmi May 12, 2026 07:29
Nasf-Fan
Nasf-Fan previously approved these changes May 12, 2026
Copy link
Copy Markdown
Contributor

@Nasf-Fan Nasf-Fan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch is fine. But I cannot understand why the original logic will cause PMEM trouble.

janekmi
janekmi previously approved these changes May 12, 2026
Copy link
Copy Markdown
Contributor

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This patch looks ok-ish but:

  1. This very odd such a bug won't cause a lot more serious issues.
  2. It is a little frightening we do not have a unit test covering this scenario.
  3. This does not solve the DAOS-18866 issue but something interesting has happened. For the first time I see one of the test cases actually PASSed. Till now either all of them have failed or all of them have PASSed. I will re-test to confirm this effect.

Ref: https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/view/change-requests/job/PR-18192/13/testReport/FTEST_ior/IorHardBasic/

Return DER_NONEXIST error when object doesn't exist for unconditional
punch.

Signed-off-by: Niu Yawei <yawei.niu@hpe.com>
@NiuYawei NiuYawei dismissed stale reviews from janekmi and Nasf-Fan via eead674 May 13, 2026 01:24
@NiuYawei
Copy link
Copy Markdown
Contributor Author

This patch looks ok-ish but:

1. This very odd such a bug won't cause a lot more serious issues.

2. It is a little frightening we do not have a unit test covering this scenario.

3. **This does not solve the DAOS-18866 issue** but something interesting has happened. For the first time I see one of the test cases actually PASSed. Till now either all of them have failed or all of them have PASSed. I will re-test to confirm this effect.

Ref: https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/view/change-requests/job/PR-18192/13/testReport/FTEST_ior/IorHardBasic/

Thanks @janekmi . I guess it could be related to the unconditional punch changes. I updated to PR to return -DER_NONEXIST before starting tx when possible (which mimics the original behavior), could retry and see if it could fully solve the issue? Thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants