DAOS-18870 DFS: Reserve a new DFS OID for GIT.#18084
DAOS-18870 DFS: Reserve a new DFS OID for GIT.#18084sherintg wants to merge 6 commits intofeature/dfs_hardlinksfrom
Conversation
Reserve a new DFS OID for the Global Index Table (GIT) used by hardlink support. Additionally bump the DFS_SB_VERSION so that older clients do not operate on containers with GIT enabled. This change: - bumps DFS_SB_VERSION from 2 to 3 - adds GIT_HI and DFS_SB_VERSION_HLS constants - reserves roots.cr_oids[2] for the GIT object at container create time - extends open_sb() to return sb_ver to mount callers - gates loading of the new roots slot on sb_ver >= DFS_SB_VERSION_HLS - stores and restores git_oid in DFS global/local handle conversion - opens and closes the GIT object handle during mount and unmount - avoids runtime OID hi collisions with the reserved GIT hi value This is plumbing only for the reserved object identity and version gating. Signed-off-by: Sherin T George <sherin-t.george@hpe.com>
|
Ticket title is 'Reserve a new DFS OID for the Global Index Table (GIT) used by hardlink support and bump SB_VERSION' |
…intg/dfs_hardlinks/DAOS-18870
mchaarawi
left a comment
There was a problem hiding this comment.
looks good to me, just a couple of nits
|
Test stage Functional on EL 9 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-18084/2/testReport/ |
Addressed review comments. Signed-off-by: Sherin T George <sherin-t.george@hpe.com>
Addressed additional review comments. Signed-off-by: Sherin T George <sherin-t.george@hpe.com>
|
Test stage Functional on EL 9 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18084/3/execution/node/997/log |
|
Test stage Functional on EL 9 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18084/4/execution/node/998/log |
knard38
left a comment
There was a problem hiding this comment.
If I am correct the OID collision issue should be fixed before landing.
Addressed additional review comments. Signed-off-by: Sherin T George <sherin-t.george@hpe.com>
|
Test stage Functional on EL 9 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-18084/5/testReport/ |
|
@daos-stack/daos-gatekeeper The clang format failure does not appear to be correct and also the functional test for EL 9 appears to be due to missing rpm. Can you please approve and merge the pull request. |
|
Removing gatekeeper for now since CI is still running |
Added Allow-unstable-test flag. Allow-unstable-test: true Signed-off-by: Sherin T George <sherin-t.george@hpe.com>
c6071fd to
194f5de
Compare
|
Test stage Functional on EL 9 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18084/7/execution/node/980/log |
Reserve a new DFS OID for the Global Index Table (GIT) used by hardlink support. Additionally bump the DFS_SB_VERSION so that older clients do not operate on containers with GIT enabled.
This change:
This is plumbing only for the reserved object identity and version gating.
Manual Testing:
2026/04/22 03:36:00.271383 delphi-018 DAOS[634484/634484/0] dfs ERR src/client/dfs/common.c:906 open_sb() Incompatible SB version: 22 (Invalid argument)
2026/04/22 03:36:00.271418 delphi-018 DAOS[634484/634484/0] dfuse ERR src/client/dfuse/dfuse_core.c:900 dfuse_cont_open(0x5641f23cb290) dfs mount() failed: 22 (Invalid argument)
Steps for the author:
After all prior steps are complete: