DAOS-18827 build: fix missing libisal2 dep in deb packages#18057
Open
DAOS-18827 build: fix missing libisal2 dep in deb packages#18057
Conversation
|
Ticket title is 'DAOS Debian package missing libisal dependency and wrong executable permissions    ' |
knard38
force-pushed
the
ckochhof/fix/master/daos-18827/patch-003
branch
from
8f398e3 to
0a66b9b
Compare
Collaborator
|
Test stage NLT completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-18057/2/testReport/ |
The --rpm-autoreq FPM option is RPM-only and silently no-ops when building Debian packages, causing the daos package to miss the libisal2 (libisal.so.2) dependency in .deb output. Remove the option and the associated noautoreq escape hatch in favour of uniform explicit dependency declarations across both packaging formats. Add the missing isal_lib dependency to the daos package. Signed-off-by: Cedric Koch-Hofer <cedric.koch-hofer@hpe.com>
knard38
force-pushed
the
ckochhof/fix/master/daos-18827/patch-003
branch
from
0a66b9b to
00262db
Compare
knard38
requested review from
daltonbohning,
grom72,
janekmi,
johannlombardi and
jolivier23
and removed request for
janekmi
daltonbohning
approved these changes
Apr 30, 2026
…/daos-18827/patch-003
johannlombardi
approved these changes
May 4, 2026
…/daos-18827/patch-003
Collaborator
|
Test stage Functional Hardware Medium MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18057/5/execution/node/1224/log |
…/daos-18827/patch-003
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The FPM
--rpm-autoreqoption automatically detects shared library dependencies by scanning ELF binaries at package build time. However, it is an RPM-only feature that is silently ignored when producing Debian packages, creating an invisible gap between the two packaging formats.As a result, the daos package's generated .deb was missing a dependency on
libisal2(providinglibisal.so.2), even though the equivalent RPM correctly pulled it in via auto-detection. This causes installation failures on Debian/Ubuntu systems wherelibisal2is not already present.To fix this and establish a consistent, auditable dependency graph across both packaging formats,
--rpm-autoreqand its associatednoautoreqescape hatch are removed fromfpm_common.shanddaos.sh. The missing${isal_lib} >= ${isal_version}dependency is explicitly added to thedaospackage, mirroring how all other dependencies are already declared.Steps for the author:
After all prior steps are complete: