DAOS-18705 rebuild: set rebuild flag before creating rebuild_pool_tls by gnailzenh · Pull Request #17941 · daos-stack/daos

gnailzenh · 2026-04-08T04:56:12Z

set rebuild flag before creating rebuild_pool_tls, otherwise aggregation
can progress to higher epoch than rebuild.
aggregation doesn't do full scan anymore after rebuild
fix a rpt refcount leak in rebuild_tgt_scan_handler()

Steps for the author:

Commit message follows the guidelines.
Appropriate Features or Test-tag pragmas were used.
Appropriate Functional Test Stages were run.
At least two positive code reviews including at least one code owner from each category referenced in the PR.
Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

Gatekeeper requested (daos-gatekeeper added as a reviewer).

- stop refreshing aggregation epoch while rebuilding - set rebuilding flag before setting rebuild fence Signed-off-by: Liang Zhen <gnailzenh@gmail.com>

github-actions · 2026-04-08T04:56:32Z

Ticket title is 'DAOS 2.6.5: Interrupt rebuild with reintegration and interrupt with exclude with active IO'
Status is 'In Progress'
Labels: 'test_2.6.5,testp1'
https://daosio.atlassian.net/browse/DAOS-18705

daosbuild3 · 2026-04-08T05:49:13Z

Test stage Unit Test completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17941/1/testReport/

Signed-off-by: Wang Shilong <shilong.wang@hpe.com>

liuxuezhao · 2026-04-08T13:05:59Z

-	/* local rebuild epoch mainly to constrain the VOS aggregation
-	 * to make sure aggregation will not cross the epoch
+	/*
+	 * XX: remove this.


you mean replace by other method?

Signed-off-by: Liang Zhen <gnailzenh@gmail.com>

daosbuild3 · 2026-04-12T20:31:02Z

Test stage Functional on EL 9 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17941/7/execution/node/1037/log

Signed-off-by: Liang Zhen <gnailzenh@gmail.com>

daosbuild3 · 2026-04-13T07:37:40Z

Test stage Functional on EL 9 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17941/8/execution/node/1032/log

wangshilong · 2026-04-13T08:22:16Z

 		;

-	epoch_range.epr_lo = epoch_min != 0 ? epoch_min + 1 : 0;
+	if (i == 0)


[minor]Perhaps to add some comments to explain even epr_lo is set to zero here, we have filter optimizations later. and this is used to guarantee aggregation could not cross snapshot.

daosbuild3 · 2026-04-13T08:30:03Z

Test stage Unit Test completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17941/9/testReport/

daosbuild3 · 2026-04-15T03:19:26Z

Test stage Functional Hardware Medium Verbs Provider MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17941/12/execution/node/640/log

daosbuild3 · 2026-04-15T07:00:30Z

Test stage Functional Hardware Medium MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17941/12/execution/node/630/log

daosbuild3 · 2026-04-15T08:35:20Z

Test stage Functional Hardware Large MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17941/12/execution/node/765/log

…#17941) (#17962) - set rebuild flag before creating rebuild_pool_tls, otherwise aggregation can progress to higher epoch than rebuild. - aggregation doesn't do full scan anymore after rebuild - fix a rpt refcount leak in rebuild_tgt_scan_handler() Signed-off-by: Liang Zhen <gnailzenh@gmail.com> Co-authored-by: Wang Shilong <shilong.wang@hpe.com> Reviewed-by: Xuezhao Liu <xuezhao.liu@hpe.com> Reviewed-by: Niu Yawei <yawei.niu@hpe.com>

Signed-off-by: Liang Zhen <gnailzenh@gmail.com>

Signed-off-by: Wang Shilong <shilong.wang@hpe.com>

Signed-off-by: Liang Zhen <gnailzenh@gmail.com>

daosbuild3 · 2026-04-17T07:08:28Z

Test stage Test RPMs on EL 9.6 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17941/14/execution/node/988/log

…#17941) (#17985) set rebuild flag before creating rebuild_pool_tls, otherwise aggregation can progress to higher epoch than rebuild. aggregation doesn't do full scan anymore after rebuild fix a rpt refcount leak in rebuild_tgt_scan_handler() Signed-off-by: Liang Zhen <gnailzenh@gmail.com> Co-authored-by: Wang Shilong <shilong.wang@hpe.com> Reviewed-by: Xuezhao Liu <xuezhao.liu@hpe.com>

DAOS-18705 rebuild: stop refreshing aggregation epoch while rebuilding

d4ba532

- stop refreshing aggregation epoch while rebuilding - set rebuilding flag before setting rebuild fence Signed-off-by: Liang Zhen <gnailzenh@gmail.com>

gnailzenh requested review from a team as code owners April 8, 2026 04:56

refine codes

00dfa69

Signed-off-by: Wang Shilong <shilong.wang@hpe.com>

wangshilong mentioned this pull request Apr 8, 2026

DAOS-18633 rebuild: global barrier for ec agg #17861

Closed

6 tasks

liuxuezhao previously approved these changes Apr 8, 2026

View reviewed changes

DAOS: code cleanup

171ecd4

Signed-off-by: Liang Zhen <gnailzenh@gmail.com>

gnailzenh dismissed liuxuezhao’s stale review via 171ecd4 April 9, 2026 14:02

gnailzenh changed the title ~~DAOS-18705 rebuild: stop refreshing aggregation epoch while rebuilding~~ DAOS-18705 rebuild: set rebuild flag before creating rebuild_pool_tls Apr 9, 2026

gnailzenh added 4 commits April 10, 2026 22:49

DAOS: remove unused epoch

cddcc5d

Signed-off-by: Liang Zhen <gnailzenh@gmail.com>

DAOS: fix the ds_pool refcount

57e7d41

Signed-off-by: Liang Zhen <gnailzenh@gmail.com>

DAOS: remove false assertion

a397658

Signed-off-by: Liang Zhen <gnailzenh@gmail.com>

DAOS: more code cleanup

510c9dd

Signed-off-by: Liang Zhen <gnailzenh@gmail.com>

gnailzenh added 3 commits April 13, 2026 10:08

DAOS: clang format fix

b797371

Signed-off-by: Liang Zhen <gnailzenh@gmail.com>

Merge branch 'master' into b_agg_epc

b5ec5b4

DAOS: revert the epoch range change

c14b947

Signed-off-by: Liang Zhen <gnailzenh@gmail.com>

gnailzenh requested review from NiuYawei and wangshilong April 13, 2026 07:50

wangshilong reviewed Apr 13, 2026

View reviewed changes

wangshilong previously approved these changes Apr 13, 2026

View reviewed changes

wangshilong requested a review from liuxuezhao April 13, 2026 08:22

NiuYawei previously approved these changes Apr 13, 2026

View reviewed changes

liuxuezhao previously approved these changes Apr 13, 2026

View reviewed changes

gnailzenh and others added 2 commits April 17, 2026 11:04

DAOS: fix the wait condition in rebuild_tgt_fini

4915ab8

Signed-off-by: Liang Zhen <gnailzenh@gmail.com>

Fix rpt wakeup and assertion

82a7a0f

Signed-off-by: Wang Shilong <shilong.wang@hpe.com>

gnailzenh dismissed stale reviews from liuxuezhao, NiuYawei, and wangshilong via 82a7a0f April 17, 2026 03:04

wangshilong previously approved these changes Apr 17, 2026

View reviewed changes

Merge branch 'master' into b_agg_epc

99bed11

liuxuezhao previously approved these changes Apr 17, 2026

View reviewed changes

DAOS: code cleanup

9e128f4

Signed-off-by: Liang Zhen <gnailzenh@gmail.com>

gnailzenh dismissed stale reviews from liuxuezhao and wangshilong via 9e128f4 April 17, 2026 04:04

gnailzenh and others added 3 commits April 22, 2026 11:39

Merge branch 'master' into b_agg_epc

d6acc4d

Merge branch 'master' of github.com:daos-stack/daos into liang/b_agg_epc

f5d0227

Merge branch 'master' into b_agg_epc

f79d630

liuxuezhao approved these changes Apr 28, 2026

View reviewed changes

wangshilong approved these changes Apr 28, 2026

View reviewed changes

gnailzenh merged commit 379be16 into master Apr 28, 2026
35 of 36 checks passed

gnailzenh deleted the liang/b_agg_epc branch April 28, 2026 06:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DAOS-18705 rebuild: set rebuild flag before creating rebuild_pool_tls#17941

DAOS-18705 rebuild: set rebuild flag before creating rebuild_pool_tls#17941
gnailzenh merged 17 commits into
masterfrom
liang/b_agg_epc

gnailzenh commented Apr 8, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 8, 2026

Uh oh!

daosbuild3 commented Apr 8, 2026

Uh oh!

liuxuezhao Apr 8, 2026

Uh oh!

daosbuild3 commented Apr 12, 2026

Uh oh!

daosbuild3 commented Apr 13, 2026

Uh oh!

wangshilong Apr 13, 2026

Uh oh!

daosbuild3 commented Apr 13, 2026

Uh oh!

daosbuild3 commented Apr 15, 2026

Uh oh!

daosbuild3 commented Apr 15, 2026

Uh oh!

daosbuild3 commented Apr 15, 2026

Uh oh!

daosbuild3 commented Apr 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

5 participants

Conversation

gnailzenh commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Steps for the author:

After all prior steps are complete:

Uh oh!

github-actions Bot commented Apr 8, 2026

Uh oh!

daosbuild3 commented Apr 8, 2026

Uh oh!

liuxuezhao Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

daosbuild3 commented Apr 12, 2026

Uh oh!

daosbuild3 commented Apr 13, 2026

Uh oh!

wangshilong Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

daosbuild3 commented Apr 13, 2026

Uh oh!

daosbuild3 commented Apr 15, 2026

Uh oh!

daosbuild3 commented Apr 15, 2026

Uh oh!

daosbuild3 commented Apr 15, 2026

Uh oh!

daosbuild3 commented Apr 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

5 participants

gnailzenh commented Apr 8, 2026 •

edited

Loading