-
Notifications
You must be signed in to change notification settings - Fork 340
SRE-3534 ci: adapt CI to use el9.7 #17376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Cancel-prev-build: false Priority: 2 Skip-build-leap15-gcc: true Allow-unstable-test: true Skip-func-hw-test-medium: false Skip-func-hw-test-medium-md-on-ssd: false Skip-func-hw-test-large: false Skip-func-hw-test-large-md-on-ssd: false Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
|
Errors are Unable to load ticket data |
Priority: 2 Skip-unit-tests:true Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
Cancel-prev-build: false Priority: 2 Allow-unstable-test: true Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
|
Test stage Unit Test bdev with memcheck on EL 9.7 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-17376/3/display/redirect |
|
Test stage Unit Test on EL 9.7 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-17376/3/display/redirect |
|
Test stage Unit Test bdev on EL 9.7 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-17376/3/display/redirect |
|
Test stage Unit Test with memcheck on EL 9.7 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-17376/3/display/redirect |
|
Test stage NLT on EL 9.7 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-17376/3/display/redirect |
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
|
Test stage Functional on EL 8.8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17376/2/execution/node/738/log |
|
Test stage Functional on EL 9.7 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17376/2/execution/node/748/log |
Cancel-prev-build: false Priority: 2 Skip-unit-tests:true Allow-unstable-test: true Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
|
Test stage Unit Test with memcheck on EL 9.7 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17376/4/testReport/ |
|
Test stage NLT on EL 9.7 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17376/4/testReport/ |
|
Test stage Unit Test bdev with memcheck on EL 9.7 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17376/4/testReport/ |
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
Cancel-prev-build: false Priority: 2 Skip-build-leap15-gcc: true Skip-unit-tests:true Skip-unit-test: true Skip-NLT: false Skip-unit-test-memcheck: true Allow-unstable-test: true Skip-func-vm: true Skip-func-hw-test-medium: false Skip-func-hw-test-medium-md-on-ssd: false Skip-func-hw-test-medium-vmd: false Skip-func-hw-test-medium-verbs-provider: false Skip-func-hw-test-medium-verbs-provider-md-on-ssd: false Skip-func-hw-test-medium-ucx-provider: false Skip-func-hw-test-large: false Skip-func-hw-test-large-md-on-ssd: false Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
Cancel-prev-build: false Priority: 2 Skip-build-leap15-gcc: true Allow-unstable-test: true Skip-func-vm: true Skip-func-hw-test: true Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
|
Test stage Unit Test with memcheck on EL 9.7 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17376/8/testReport/ |
|
Test stage NLT on EL 9.7 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17376/8/testReport/ |
|
Test stage Unit Test bdev with memcheck on EL 9.7 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17376/8/testReport/ |
Cancel-prev-build: false Priority: 2 Skip-build-leap15-gcc: true Skip-unit-tests:true Skip-unit-test: true Skip-NLT: true Skip-unit-test-memcheck: true Skip-func-vm: true Skip-func-test-vm-valgrind: true Skip-func-test-el8: true Skip-func-test-el9: true Skip-func-test-leap15: true Skip-fault-injection-test: true Skip-test-el-9.6-rpms: false Skip-test-leap-15-rpms: true Skip-func-hw-test-medium: false Skip-func-hw-test-medium-md-on-ssd: false Skip-func-hw-test-medium-vmd: false Skip-func-hw-test-medium-verbs-provider: false Skip-func-hw-test-medium-verbs-provider-md-on-ssd: false Skip-func-hw-test-medium-ucx-provider: false Skip-func-hw-test-large: false Skip-func-hw-test-large-md-on-ssd: false Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
Cancel-prev-build: false Priority: 2 Skip-build-leap15-gcc: true Skip-unit-tests:true Skip-unit-test: true Skip-NLT: false Skip-unit-test-memcheck: true Allow-unstable-test: true Skip-func-vm: true Skip-func-test-vm-valgrind: true Skip-func-test-el8: true Skip-func-test-el9: true Skip-func-test-leap15: true Skip-fault-injection-test: true Skip-test-el-9.6-rpms: true Skip-test-leap-15-rpms: true Skip-func-hw-test: false Skip-func-hw-test-medium: false Skip-func-hw-test-medium-md-on-ssd: false Skip-func-hw-test-medium-vmd: false Skip-func-hw-test-medium-verbs-provider: false Skip-func-hw-test-medium-verbs-provider-md-on-ssd: false Skip-func-hw-test-medium-ucx-provider: false Skip-func-hw-test-large: false Skip-func-hw-test-large-md-on-ssd: false Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
|
Test stage Functional on EL 9.7 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-17376/10/display/redirect |
JohnMalmberg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some general comments for potentially future cleanup.
| } | ||
| } | ||
| stage('Build on EL 9.6') { | ||
| stage('Build on EL 9.7') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For EL distros we generally intentionally build on el-X.Y older than current. Sometimes even numbered releases can have longer term support, and code built for el-9 of any older release in general should work on any older release.
| } | ||
| parallel { | ||
| stage('Unit Test on EL 8.8') { | ||
| stage('Unit Test on EL 9.7') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not be specifying the point release for tests, we should always test on the current point release.
We should also have the ability of a PR to test on a beta release of a point release. Currently our testing infrastructure is not setup to provide beta releases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just FYI that changing the names of these stages means the landing requirements need to be updated. I'll handle that when landing
| testResults: 'nlt-junit.xml', | ||
| always_script: 'ci/unit/test_nlt_post.sh', | ||
| valgrind_stash: 'el8-gcc-nlt-memcheck' | ||
| valgrind_stash: 'el9-gcc-nlt-memcheck' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pipeline-lib routine parseStageInfo should be providing the default value for the valgrind stash to make sure that it is correct and consistent instead of having to maintain this edit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO we should not rely on such a function to parse the stage name to determine the stash name. Functions of that nature have proven to be notorious to debug, modify, or even understand the flow.
It might be redundant here but I think this approach is actually better.
| } | ||
| } // stage('Functional on EL 8.8') | ||
| stage('Functional on EL 9') { | ||
| stage('Functional on EL 9.7') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We control what el-9 point release is used for outside of Jenkins for these tests. The only time we don't want to test the current version is if we need to fix a problem with using the current point release, and the usual problem is that we are waiting for a custom driver from the high speed network adapter vendor, and that only affects hardware tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1. I think this should stay as Functional on EL 9. It also means we won't have to change the landing requirements for this one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The intention of this change is to clearly indicate which version of OS we actually fully support.
This stems from release requirements, e.g., for 2.8, support for el9.7, and it is not clear anywhere whether this is maintained.
The alternative solution is to keep the original name, but start using the distro parameter in the getFunctionalTestStage function in Jenkinsfile
https://github.com/daos-stack/pipeline-lib/blob/cb2788756bc1179cda14db3c21650b05e400b175/vars/getFunctionalTestStage.groovy#L20
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do think it's better to specify the distro explicitly. Putting 9.7 in the name of the stage does not necessarily mean we are running on 9.7. It's just a name.
Also, variables like CI_FUNCTIONAL_el9_TEST do not have the point release in them so omitting the point release in the name keeps them consistent.
|
Test stage Functional Hardware Medium UCX Provider completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17376/11/execution/node/756/log |
|
Test stage Functional Hardware Large completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17376/11/execution/node/674/log |
| // To use a test branch (i.e. PR) until it lands to master | ||
| // I.e. for testing library changes | ||
| //@Library(value='pipeline-lib@your_branch') _ | ||
| @Library(value='pipeline-lib@grom72/SRE-3522') _ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to selves: we need to remove before landing
| } | ||
| parallel { | ||
| stage('Unit Test on EL 8.8') { | ||
| stage('Unit Test on EL 9.7') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just FYI that changing the names of these stages means the landing requirements need to be updated. I'll handle that when landing
| testResults: 'nlt-junit.xml', | ||
| always_script: 'ci/unit/test_nlt_post.sh', | ||
| valgrind_stash: 'el8-gcc-nlt-memcheck' | ||
| valgrind_stash: 'el9-gcc-nlt-memcheck' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO we should not rely on such a function to parse the stage name to determine the stash name. Functions of that nature have proven to be notorious to debug, modify, or even understand the flow.
It might be redundant here but I think this approach is actually better.
| } | ||
| } // stage('Functional on EL 8.8') | ||
| stage('Functional on EL 9') { | ||
| stage('Functional on EL 9.7') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1. I think this should stay as Functional on EL 9. It also means we won't have to change the landing requirements for this one
|
Test stage Functional Hardware Large MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17376/11/execution/node/922/log |
|
Test stage Functional Hardware Medium UCX Provider completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17376/16/execution/node/818/log |
|
Test stage Functional Hardware Large completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17376/16/execution/node/767/log |
|
Test stage Functional Hardware Large MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17376/16/execution/node/757/log |
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com> Cancel-prev-build: false Priority: 2 Allow-unstable-test: true Skip-func-test-vm-valgrind: false Skip-func-test-el8: false Skip-func-test-el9: false Skip-func-hw-test-medium: false Skip-func-hw-test-medium-md-on-ssd: false Skip-func-hw-test-medium-vmd: false Skip-func-hw-test-medium-verbs-provider: false Skip-func-hw-test-medium-verbs-provider-md-on-ssd: false Skip-func-hw-test-medium-ucx-provider: false Skip-func-hw-test-large: false Skip-func-hw-test-large-md-on-ssd: false
|
Test stage NLT on EL 9.7 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17376/19/testReport/ |
|
Test stage Unit Test with memcheck on EL 9.7 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17376/19/testReport/ |
|
Test stage Unit Test bdev with memcheck on EL 9.7 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17376/19/testReport/ |
This PR upgrades the majority of the CI test stages so that they are run on EL9.7.
Requires:
Steps for the author:
After all prior steps are complete: