29 create chat view #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a new chat view option in the social media app, alongside the existing thread view. It includes: - New ViewProvider context to manage view state (chat/thread) - Enhanced Reply and CanvasPreview components to support chat-message variant - Added "chat" as a new sort criteria option in the dropdown - Auto-switching between views based on sort criteria selection - UI improvements for the chat view with appropriate styling The changes allow users to toggle between thread and chat display modes for better conversation flow. Note: This is work in progress and may need further UI refinements and testing.
…atures - Add left/right message alignment based on sender identity - Improve chat bubble styling and container dimensions - Implement proper avatar sizing in message headers - Fix chat view sorting to display messages chronologically - Add isMe utility function to identify user's messages across devices - Fix height and spacing issues in conversation components
Open
BREAKING CHANGE: Reply component API changed to use variant prop instead of separate view/variant props - Refactor Preview component into smaller, focused subcomponents - Improve type safety with discriminated union types for preview variants - Restructure Reply component to use CSS grid for better layout control - Add chat message alignment support with left/right positioning - Extract blur background into separate reusable component - Fix typo in separateAndSortRects function name - Add utility for combining Tailwind classes - Improve code organization and readability throughout
| return devices.some((connection) => { | ||
| return ( | ||
| Buffer.from(connection.device1.publicKey).equals( | ||
| Buffer.from(keyBytes) |
There was a problem hiding this comment.
I am suprised how your editor works because Buffer.from(connection.device1.publicKey). should give Typescript compile errors. If you want to access the bytes of the key you can do
connection.device1.publicKey.bytes.
But I am also curious what part of the chat view requires the isMe function
- Add type safety to tailwind utility functions - Optimize breadcrumb navigation layout and sizing - Add JSDoc documentation to content components - Clean up conditional class name assignments - Add markdown parsing utilities for preview text
…ples into 29-create-chat-view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.