Update line breaks/carriage returns count as 2 characters #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcheuD
approved these changes
Jun 18, 2021
|
@karthikbodu I believe you are incorrect. A normal line break in the SMS context consists of two characters called CR and LF. (CR and LF corresponds to '\r' and '\n'.) They shall be counted as separate characters, which they are in the current implementation. (You may of course create your own "compiler" on top of the current solution that does this for you, but the current solution is correct.) See chapter 4 in ETSI TS 123 038 v 10.0.0. (I know there are later versions, but I cannot see any reason for changing this. Backwards compatibility is too important.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.