Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving image generator #45

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Conversation

danschultzer
Copy link
Owner

This adds the missing features discussed in #30.

The rotation and gradient already cause problems for OpenCV preprocessor so it might be a good idea to try to improve the preprocessor already.

@codecov-io
Copy link

codecov-io commented Nov 29, 2016

Codecov Report

Merging #45 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #45      +/-   ##
=========================================
- Coverage    98.7%   98.7%   -0.01%     
=========================================
  Files          16      16              
  Lines         463     462       -1     
=========================================
- Hits          457     456       -1     
  Misses          6       6
Impacted Files Coverage Δ
lib/image_processor/preprocessor/opencv.js 99.36% <100%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be22b50...b4ec43c. Read the comment docs.

@danschultzer
Copy link
Owner Author

Also, this can be run now to speed up benchmark: npm run benchmark -- --preprocessors opencv --verbose

Useful for testing.

With the current seed of 474523310 I get 70% success rate:

npm run generate-benchmark-sample -- --seed=474523310
npm run benchmark -- --preprocessors opencv --verbose

@danschultzer
Copy link
Owner Author

Added ability to disable modifiers to ease up testing a variety, and check success rate for certain traits.

@danschultzer danschultzer force-pushed the updated-image-generator branch 3 times, most recently from 09d3aee to 01027cd Compare November 30, 2016 19:38
@danschultzer danschultzer mentioned this pull request Mar 27, 2018
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants