fixed custom "MQTT Topic Format" and newer phpMQTT.php #56
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that the code didn't work when I had a "MQTT Topic Format" value populated in the settings.
Mine is
tasmota/%topic%/%prefix%
The
lib/mqtt.inc.php
wasn't working, but I think there was a problem with thephpMQTT.php
library.So, I updated that and also then amended the
mqtt.inc.php
subscribe functions to handle the "MQTT Topic Format". There was a condition missing for the "name".There was some updates on the phpMQTT.php library, and this version worked for me - so I included a copy of that version in this pull request.