improved simplecpp::TokenList constructors
#599
Draft
+161
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firewave
changed the title
simplecpp::View to clean up simplecpp::TokenList constructorssimplecpp::View to clean up simplecpp::TokenList constructors
firewave
force-pushed
the
view
branch
2 times, most recently
from
789bda9 to
431c397
Compare
This comment was marked as outdated.
This comment was marked as outdated.
firewave
changed the title
simplecpp::View to clean up simplecpp::TokenList constructorssimplecpp::View to be able to write portable code
Collaborator
Author
|
Required to address https://trac.cppcheck.net/ticket/14267. |
firewave
changed the title
simplecpp::View to be able to write portable codesimplecpp::TokenList constructors
firewave
commented
Dec 10, 2025
| { | ||
| std::vector<std::string> filenames; | ||
| { | ||
| char input[] = "code"; // NOLINT(misc-const-correctness) |
Collaborator
Author
There was a problem hiding this comment.
This is not actually reported but pre-emptively added in case it is detected in the future. I added a comment about it upstream: llvm/llvm-project#56758 (comment)
firewave
force-pushed
the
view
branch
2 times, most recently
from
34d5cb3 to
27716f3
Compare
Collaborator
Author
|
Requires #606 to be merged first. |
…nList` code and added tests for all inputs
Collaborator
Author
|
We can tag 1.6.4 after this has been merged, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simplecpp::Viewto be able to write code which is compatible with C++11 and => C++17