Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #334 Do not assert when source file is missing #333

Merged
merged 6 commits into from
Feb 2, 2024

Conversation

olabetskyi
Copy link
Contributor

No description provided.

Copy link
Owner

@danmar danmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would think it should be relatively easy to unit test the simplecpp::TokenList::TokenList constructor

simplecpp.cpp Outdated Show resolved Hide resolved
simplecpp.cpp Outdated Show resolved Hide resolved
@olabetskyi olabetskyi changed the title Fix #11797 crash on missing/renamed files #334 Do not assert when source file is missing Feb 2, 2024
simplecpp.cpp Outdated Show resolved Hide resolved
@olabetskyi olabetskyi changed the title #334 Do not assert when source file is missing Fix #334 Do not assert when source file is missing Feb 2, 2024
test.cpp Outdated Show resolved Hide resolved
Copy link
Owner

@danmar danmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when ci is happy we can merge this

@danmar danmar merged commit ea78f9a into danmar:master Feb 2, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants