Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplecpp.h: push and pop the MSVC warning disabling #pragma so they don't spill into user code #306

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

firewave
Copy link
Collaborator

Those were introduced by #298.

@firewave
Copy link
Collaborator Author

I would still prefer not to have warnings disabled in the code but that can still be discussed after. At least fix them for now.

@danmar danmar merged commit ff94646 into danmar:master Aug 23, 2023
13 checks passed
@firewave firewave deleted the warn-push-pop branch August 23, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants