-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Docs: Explain the release build. And also how-to install Cppcheck #8044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Docs: Explain the release build. And also how-to install Cppcheck #8044
Conversation
| cmake --build build | ||
| ``` | ||
|
|
||
| デフォルトのビルドタイプは `Debug` です。`Release` ビルドが必要な場合は、ビルドフラグ (上記の最初の `cmake` コマンドで) を使用できます。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you know japanese well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I'm wondering why you have a japense readme if you don't speak it 🤣? The Japanese readme is very outdated actually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know any japanese.
It has been updated now and then by a japanese guy. I don't want to have some auto translations that we don't know if they are proper or not. So the choice should be either to:
- find somebody that really speaks japanese that wants to maintain this
- remove it
@fu7mu4 are you interested to review/update the file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove what.. I think the cmake commands were outdated (like how to build it) so I would like to keep that to be honest.. but we can also remove the whole Japense readme file.
|
|
||
| For building the tests use the flag. | ||
| -DBUILD_TESTS=ON | ||
| For rules support (requires pcre) use the flag: `-DHAVE_RULES=ON` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can use this change to explain what rules are and if one should enable it or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for information my idea is to get rid of pcre and use std::regex instead. the pcre library we use is end of life. there is work in progress..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep in mind that std::regex is very slow.
Do I need Rules support for the full functionality of cppcheck or only when I want to write custom rules?
|



Also explain how to use cmake to install the compiled target to your machine(@danmar doesn't want this documented)