Skip to content

Conversation

@GNL10
Copy link
Contributor

@GNL10 GNL10 commented Oct 25, 2025

No description provided.

@GNL10
Copy link
Contributor Author

GNL10 commented Oct 25, 2025

Currently after the UTs finish there is a file that does not get deleted (e.g. outputfile_18314070737314589129.plist).
This is caused by the UT added in this PR. When reportErr is called inside in the negative scenario.

Not entirely sure what the most appropriate way to delete that file should be.

GNL10 added 2 commits October 27, 2025 23:32
When file does not have suffix, the full name is used.
@danmar
Copy link
Owner

danmar commented Oct 28, 2025

I like this PR. But CI fails right now.

@danmar
Copy link
Owner

danmar commented Oct 28, 2025

strange it seems to complain about the test you added:
https://github.com/danmar/cppcheck/actions/runs/18859083744/job/53813515383?pr=7911#step:11:132

@sonarqubecloud
Copy link

@GNL10
Copy link
Contributor Author

GNL10 commented Oct 28, 2025

strange it seems to complain about the test you added: https://github.com/danmar/cppcheck/actions/runs/18859083744/job/53813515383?pr=7911#step:11:132

Test was failing due to the hash function giving different output depending on the platform type.
Should be good now!

@danmar danmar merged commit 3b1485f into danmar:main Oct 28, 2025
55 checks passed
@danmar
Copy link
Owner

danmar commented Oct 28, 2025

I merged this PR.. I would like to add your name in the AUTHORS file.. should I write Goncalo Mao-Cheia?

@GNL10
Copy link
Contributor Author

GNL10 commented Oct 28, 2025

I merged this PR.. I would like to add your name in the AUTHORS file.. should I write Goncalo Mao-Cheia?

Yes "Goncalo Mao-Cheia" is fine. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants