-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add check for npos, when checkInternal receives file with missing dot #7911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add check for npos, when checkInternal receives file with missing dot #7911
Conversation
|
Currently after the UTs finish there is a file that does not get deleted (e.g. outputfile_18314070737314589129.plist). Not entirely sure what the most appropriate way to delete that file should be. |
When file does not have suffix, the full name is used.
|
I like this PR. But CI fails right now. |
|
strange it seems to complain about the test you added: |
|
Test was failing due to the hash function giving different output depending on the platform type. |
|
I merged this PR.. I would like to add your name in the AUTHORS file.. should I write |
Yes "Goncalo Mao-Cheia" is fine. Thanks! |



No description provided.