Skip to content

added CMake option USE_INT128 and support built-in __int128 / some compilation fixes #7840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

added CMake option USE_INT128 and support built-in __int128 / some compilation fixes #7840

wants to merge 3 commits into from

Conversation

firewave
Copy link
Collaborator

No description provided.

@firewave
Copy link
Collaborator Author

firewave commented Sep 22, 2025 •
edited
Loading

See also #7833 (comment).

Using __int128 it almost fully builds except for the requirement on ValueFlow::Value::equalTo() (suggestions on how to address it in this PR are welcome). The conversion to string for actual 128-bit values does not exist yet but this already exposes overflow issues in the existing code.

firewave
firewave commented Sep 22, 2025
View reviewed changes
cmake/compilerDefinitions.cmake
Comment on lines +46 to 48
if(USE_INT128 AND USE_BOOST_INT128)
add_definitions(-DHAVE_BOOST_INT128)
endif()
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the logic around USE_BOOST_INT128 is flawed . On is supposed to force the usage of Boost and Auto should provide a fallback to Boost if no built-in type exists but Boost is enabled (i.e. Visual Studio).

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm.. how about:

VALUEFLOW_INT128=no
VALUEFLOW_INT128=gcc
VALUEFLOW_INT128=boost

?

@firewave firewave marked this pull request as draft September 22, 2025 08:13
@firewave firewave force-pushed the i128 branch 10 times, most recently from 8cea4f1 to 9e1502e Compare September 22, 2025 08:49
@firewave firewave marked this pull request as ready for review September 22, 2025 08:58
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@firewave
Copy link
Collaborator Author

The conversion to string for actual 128-bit values does not exist yet but this already exposes overflow issues in the existing code.

I filed https://trac.cppcheck.net/ticket/14154 about that.

pfultz2
pfultz2 suggested changes Sep 27, 2025
View reviewed changes
Copy link
Contributor

@pfultz2 pfultz2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#7658 should be merged first before this pr. This adds another flag that needs to be added every where. #7658 already fixes that so this PR should be based on # 7658.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danmar danmar danmar left review comments

+1 more reviewer

@pfultz2 pfultz2 pfultz2 requested changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@firewave @danmar @pfultz2