-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Improve documentation for --enable=all flag #7836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks for your contribution. This does not feel like an improvement and rather just duplicates the documentation of the other options. And the example is unnecessary and invalid (whitespaces). What was you motivation to adjust this? The existing wording about the whole program stuff is a bit vague and could be improved though. |
bde1c3b
to
dcd6da9
Compare
Thanks for the feedback! You’re right — my initial change ended up duplicating information that’s already documented elsewhere, and the example wasn’t necessary. The main motivation was that the current wording about “whole program” felt vague. I’ve now revised the help text to focus only on clarifying that part, without duplicating other docs. |
dcd6da9
to
91519a3
Compare
Agreed.
I think the We should also check what the actual manual/manpage says about this. I think |
Thanks, that makes sense. 👍 I’ll adjust the wording to: --enable=all Enable all the following checks. Also, I agree that the current --help output is too verbose. Introducing a way to get more detailed help for a single option in a future CLI help rework sounds like a great idea. |
|
I still don't think this is an improvement. Some thoughts:
|
Improved help text for --enable=all flag: listed included checks, explained caution, added example usage.