got rid of unnecessary ExprIdToken constructors
#7728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firewave
commented
Aug 8, 2025
| // TODO: Make this constructor only available from ProgramMemory | ||
| // cppcheck-suppress noExplicitConstructor | ||
| // NOLINTNEXTLINE(google-explicit-constructor) | ||
| ExprIdToken(nonneg int exprid) : exprid(exprid) {} |
There was a problem hiding this comment.
This was only used for lookups/comparisons.
|
A cleanup ahead of #7295. |
firewave
commented
Aug 8, 2025
| } | ||
|
|
||
| bool ProgramMemory::hasValue(nonneg int exprid) | ||
| bool ProgramMemory::hasValue(nonneg int exprid) const |
There was a problem hiding this comment.
Detecting this is tracked in https://trac.cppcheck.net/ticket/12162.
There was a problem hiding this comment.
Actually. With my changes this might have been caught now.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.