Add notify bell function#1
Open
angelovianajr wants to merge 3 commits into
Open
Conversation
danielpires
requested changes
Jul 16, 2025
Owner
danielpires
left a comment
danielpires
left a comment
There was a problem hiding this comment.
I love this feature, is there a way to not spam the user with bell rings? like a cool down period for an already notified used
danielpires
requested changes
Jul 17, 2025
danielpires
requested changes
Jul 21, 2025
Comment on lines
+277
to
+284
| if (user.name !== username) { | ||
| const bellButton = document.createElement("button"); | ||
| bellButton.className = "bell-button"; | ||
| bellButton.innerHTML = "🔔"; | ||
| bellButton.onclick = () => notifyUser(user.name); | ||
| bellButton.title = `Notify ${user.name}`; | ||
| seat.appendChild(bellButton); | ||
| } |
Owner
There was a problem hiding this comment.
to avoid abuse let's have this bell only if the player hasn't voted yet, and at least the majority of player in the room already voted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.