Fix supervised pairing when device already trusts supervisor certificate #656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using supervised pairing (ios pair --p12file), if the device already trusts the supervisor certificate, it returns an EscrowBag immediately without requiring a challenge. The code incorrectly treated this as an error with message: "the response is missing the Error key: map[EscrowBag:...]" This fix: - Detects when pairing succeeds on the first request (EscrowBag present) - Skips the challenge-response flow in that case - Also fixes typo: "missign" -> "missing" 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ios pair --p12file) when the device is already paired using the standard pairingEscrowBagimmediately without requiring a challenge, but the code incorrectly treated this as an errorProblem
When pairing a supervised device that already trusts the supervisor certificate, the error was:
The code expected an
MCChallengeRequirederror with a challenge to sign, but the device skipped that step and returned success directly.Solution
Test plan
🤖 Generated with Claude Code