Fix RelationshipMemory hook: parsed.userPrompt doesn't exist#1049
Open
qozle wants to merge 1 commit intodanielmiessler:mainfrom
Open
Fix RelationshipMemory hook: parsed.userPrompt doesn't exist#1049qozle wants to merge 1 commit intodanielmiessler:mainfrom
qozle wants to merge 1 commit intodanielmiessler:mainfrom
Conversation
…ield The v4.0.0 refactor to use shared TranscriptParser left a reference to parsed.userPrompt, which doesn't exist on ParsedTranscript. This made the hook silently skip all user messages. The plainCompletion fallback for assistant content is a short tab-title string, too narrow for relationship pattern regexes to match. Parse user and assistant messages directly from parsed.raw JSONL lines, using the same contentToText() helper that TranscriptParser uses internally. Fixes danielmiessler#971 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RelationshipMemory.hook.tsreferencesparsed.userPromptwhich doesn't exist onParsedTranscript— alwaysundefined, so user messages are never capturedparsed.plainCompletion(tab-title string) is too short for relationship pattern regexes to match against assistant contentparsed.rawJSONL lines using the existingcontentToText()helper, matching the same approach used internally byparseLastAssistantMessage()andcollectCurrentResponseText()Test plan
MEMORY/RELATIONSHIP/SUMMARY:lines in assistant output and verify biographical notes are capturedFixes #971