security: replace execSync with execFileSync in tab-setter.ts#1046
Open
qozle wants to merge 1 commit intodanielmiessler:mainfrom
Open
security: replace execSync with execFileSync in tab-setter.ts#1046qozle wants to merge 1 commit intodanielmiessler:mainfrom
qozle wants to merge 1 commit intodanielmiessler:mainfrom
Conversation
execSync() with string interpolation is vulnerable to command injection via KITTY_LISTEN_ON env var or tab title content. Switches all shell commands to execFileSync() with array args (no shell spawned), adds socket path validation regex, and replaces the jq shell pipeline with native JSON.parse(). Closes danielmiessler#1045
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tab-setter.tsusesexecSync()with string interpolation to build kitten commands — vulnerable to command injection viaKITTY_LISTEN_ONenv var or tab title contentexecSynccalls withexecFileSyncusing array arguments (no shell spawned, no injection surface)jqshell pipeline incleanupStaleStateFiles()with nativeJSON.parse()What changed
Three functions updated:
cleanupStaleStateFiles()—execSync+ jq pipeline →execFileSync+JSON.parse()+ socket validationsetTabState()—execSyncstring interpolation →execFileSyncarray argssetPhaseTab()— same patternTest plan
",$, backticks) render correctly without injectionCloses #1045