Skip to content

fix: cross-platform desktop notifications in VoiceServer #1030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
qozle wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: cross-platform desktop notifications in VoiceServer #1030

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 19 additions & 5 deletions Releases/v4.0.3/.claude/VoiceServer/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,23 @@ function escapeForAppleScript(input: string): string {
return input.replace(/\\/g, '\\\\').replace(/"/g, '\\"');
}

// Send desktop notification using OS-appropriate mechanism
async function sendDesktopNotification(title: string, message: string): Promise<void> {
const platform = process.platform;
if (platform === 'darwin') {
const escapedTitle = escapeForAppleScript(title);
const escapedMessage = escapeForAppleScript(message);
const script = `display notification "${escapedMessage}" with title "${escapedTitle}" sound name ""`;
await spawnSafe('/usr/bin/osascript', ['-e', script]);
} else if (platform === 'linux') {
if (existsSync('/usr/bin/notify-send')) {
await spawnSafe('/usr/bin/notify-send', [title, message]);
} else {
console.log('⚠️ notify-send not found — skipping desktop notification');
}
}
}

// Extract emotional marker from message
function extractEmotionalMarker(message: string): { cleaned: string; emotion?: string } {
const emojiToEmotion: Record<string, string> = {
Expand Down Expand Up @@ -512,13 +529,10 @@ async function sendNotification(
}
}

// Display macOS notification (can be disabled via settings.json: notifications.desktop.enabled: false)
// Display desktop notification (can be disabled via settings.json: notifications.desktop.enabled: false)
if (voiceConfig.desktopNotifications) {
try {
const escapedTitle = escapeForAppleScript(safeTitle);
const escapedMessage = escapeForAppleScript(safeMessage);
const script = `display notification "${escapedMessage}" with title "${escapedTitle}" sound name ""`;
await spawnSafe('/usr/bin/osascript', ['-e', script]);
await sendDesktopNotification(safeTitle, safeMessage);
} catch (error) {
console.error("Notification display error:", error);
}
Expand Down