fix(telos): rename LESSONS.md to LEARNED.md and fix Update.md script path#1024
Open
badosanjos wants to merge 2 commits intodanielmiessler:mainfrom
Open
fix(telos): rename LESSONS.md to LEARNED.md and fix Update.md script path#1024badosanjos wants to merge 2 commits intodanielmiessler:mainfrom
badosanjos wants to merge 2 commits intodanielmiessler:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two bugs in the Telos skill that cause the TELOS update command to silently fail:
Bug 1 — Wrong filename:
LESSONS.mdvsLEARNED.mdSKILL.mdconsistently documents the lessons file asLEARNED.md:But
Tools/UpdateTelos.tsVALID_FILES andWorkflows/Update.mdboth referenceLESSONS.md.Effect: The file on disk is
LEARNED.md. If a user tries to update it:update-telos LEARNED.md ...) →❌ Invalid file: LEARNED.mdupdate-telos LESSONS.md ...) →❌ File does not existBoth paths fail. Lessons cannot be updated at all.
Bug 2 — Stale script path in
Update.mdWorkflows/Update.mdinvokes the update script as:bun ~/.claude/commands/update-telos.tsBut
~/.claude/commands/does not exist. The correct installed path is:bun ~/.claude/skills/Telos/Tools/UpdateTelos.tsThis was partially addressed in #930/#929 for
UpdateTelos.tsbut not forUpdate.md.Changes
Packs/Telos/src/Tools/UpdateTelos.ts— renamed'LESSONS.md'→'LEARNED.md'in VALID_FILES array and JSDoc commentPacks/Telos/src/Workflows/Update.md— renamed allLESSONS.md→LEARNED.mdreferences; fixed script invocation path from~/.claude/commands/update-telos.tsto~/.claude/skills/Telos/Tools/UpdateTelos.tsTest plan
update-telos LEARNED.md "- New lesson" "Test lesson"succeeds (was rejected as invalid file)update-telos LESSONS.md "..." "..."correctly rejected (file doesn't exist)LEARNED.mdappears in the valid files list printed by the workflow🤖 Generated with Claude Code