-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define __all__ #625
Define __all__ #625
Conversation
Please move this to the end of the file, because honestly it's not something I want to see |
Also please can you change this to a tuple not a list |
It is defined at the top of the file on purpose, as suggested by PEP-8: https://peps.python.org/pep-0008/#module-level-dunder-names |
Please can you add a test that this exists and avoids importing dataclasses etc? |
I have never seen it go before module imports hmm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the python docs say it should go before imports, then okay.
I added a test that check that |
Summary
Define
__all__
in the generated files, as suggested by #486Checklist