Repository navigation
Overhaul dandi-cli testing matrix with explicit schema_install dimension - #396
Merged
Merged
Conversation
Replace the ad-hoc mode-based matrix with a clear `schema_install` dimension that explicitly controls where dandischema is installed: - `client`: dandischema installed only into the client (all OSes, released + master dandi-cli) - `server`: dandischema installed only into the server Docker image (Ubuntu, master dandi-cli only) - `both`: dandischema installed into both client and server (Ubuntu, both masters) Additional changes: - Remove useless `dandi-devel` mode (DANDI_DEVEL=1 does not affect tests) - Remove associated Python 3.10 entries and hdf5 installation steps - Keep vendorized (ember-dandi) testing with `schema_install: both` - Conditionalize "Install dandischema" step on `schema_install != 'server'` - Conditionalize Docker image build on `schema_install != 'client'` Closes #351 https://claude.ai/code/session_01RgrGZVVM44FN7LnGhexiB9
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #396 +/- ##
=======================================
Coverage 97.92% 97.92%
=======================================
Files 18 18
Lines 2405 2405
=======================================
Hits 2355 2355
Misses 50 50
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
claude: coverage remained the same, CI is green , changes making sense overall, let's proceed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
schema_installmatrix dimension (client/server/both) to explicitly control where dandischema is installed during dandi-cli integration testsdandi-develmode (DANDI_DEVEL=1does not affect dandi-cli tests) along with associated Python 3.10 entries and hdf5 installation stepsschema_install: bothNew matrix (9 jobs)
schema_install: clientschema_install: serverschema_install: bothschema_install: both+ ember-dandiThis matches the desired testing matrix from the issue:
Coverage impact
None — only
test-dandi-cli.ymlis modified, and it does not report code coverage. The coverage-reporting workflows (test.yml,test-nonetwork.yml) are untouched.Test plan
yaml.safe_load)schema_install: clientjobs skip the Docker build stepschema_install: serverjobs skip the dandischema pip install stepschema_install: bothjobs run both dandischema install and Docker buildCloses #351
https://claude.ai/code/session_01RgrGZVVM44FN7LnGhexiB9