Skip to content

CI: start coverage before pytest loads dandi's plugin #1951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yarikoptic merged 2 commits into from
Oct 6, 2026
Merged

CI: start coverage before pytest loads dandi's plugin #1951

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
36facdc
CI: start coverage before pytest loads dandi's plugin
claude Oct 6, 2026
06343e3
Merge branch 'master' into claude/coverage-run-before-plugins
CodyCBakerPhD Oct 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .github/workflows/run-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,8 +142,12 @@ jobs:

- name: Run all tests except those involving obolibrary
if: matrix.mode != 'dandi-api' && matrix.mode != 'obolibrary-only' && matrix.mode != 'lowest-deps'
# Start coverage before pytest, which loads dandi's pytest plugin (and
# thus imports most of dandi) before pytest-cov would start it
run: |
python -m pytest -s -v -m "not obolibrary" --cov=dandi --cov-report=xml dandi
python -m coverage run -m pytest -s -v -m "not obolibrary" dandi
python -m coverage combine

@yarikoptic yarikoptic Oct 6, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ha -- I think we do call external dandi CLI , so likely we might benefit from what @asmacdo + mate dug up for con-duct and I added for datalad: https://github.com/datalad/datalad/pull/7952/changes#diff-834e9b406d74791ffbafaeec9cc894082cea9739bc347b6ff9f72312c92ebc79R1

which is to add

❯ head -n 3 ~datalad/datalad/.coveragerc
[run]
# also measure Python subprocesses: datalad CLI, special remotes, ...
patch = subprocess

so might boost coverage even more???

@yarikoptic yarikoptic Oct 6, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first let's current run finish / merge may be to get this boost in ;)

@CodyCBakerPhD CodyCBakerPhD Oct 6, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes indeed, it might: #1953

python -m coverage xml

- name: Run tests against minimum declared dependency versions
if: matrix.mode == 'lowest-deps'
Expand All @@ -168,7 +172,9 @@ jobs:
if: matrix.mode == 'dandi-api'
run: |
export DANDI_TESTS_AUDIT_CSV=/tmp/audit.csv
python -m pytest -s -v --cov=dandi --cov-report=xml --dandi-api dandi
python -m coverage run -m pytest -s -v --dandi-api dandi
python -m coverage combine
python -m coverage xml
if [ ! -e /tmp/audit.csv ]
then echo Audit file not created
exit 1
Expand Down
Loading