fix doc #23
Open
fix doc #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MoonBall
commented
Jan 14, 2022
| @@ -392,7 +392,7 @@ is of a certain type, like `IsUndefined()`, `IsNull`, `IsNumber` etc. | |||
| It also has useful methods to convert to a Local<T>, for example: | |||
| ```c++ | |||
| V8_WARN_UNUSED_RESULT MaybeLocal<Number> ToNumber(Local<Context> context) const; | |||
| V8_WARN_UNUSED_RESULT MaybeLocal<String> ToNumber(Local<String> context) const; | |||
| V8_WARN_UNUSED_RESULT MaybeLocal<String> ToString(Local<Context> context) const; | |||
There was a problem hiding this comment.
The example code is from https://github.com/v8/v8/blob/ee74e718339223345b42935e9f4cbc7be208e557/include/v8-value.h#L355-L361
MoonBall
commented
Jan 14, 2022
| Contains a number of Local/Handle's (think pointers to objects but is managed | ||
| by V8) and will take care of deleting the Local/Handles for us. HandleScopes | ||
| are stack allocated | ||
| Contains a number of local handles (like pointers to objects but are managed |
There was a problem hiding this comment.
In v8's source code, they use local handles rather than Local/Handles.
There was a problem hiding this comment.
I think Local is essentially equivalent to Handle. The difference of them is Local is an outer api and Handle is an inner api.
So we can simplify the doc by omitting the Local.
MoonBall
commented
Jan 16, 2022
| @@ -706,7 +708,7 @@ So a Local contains a pointer to type T. We can access this pointer using | |||
|
|
|||
| We can cast from a subtype to a supertype using Local::Cast: | |||
| ```c++ | |||
| v8::Local<v8::Number> nr = v8::Local<v8::Number>(v8::Number::New(isolate_, 12)); | |||
| v8::Local<v8::Number> nr = v8::Number::New(isolate_, 12); | |||
There was a problem hiding this comment.
Since v8::Number::New return v8::Local<v8::Number>, we can remove unnecessary type conversion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modify doc