-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed issue (#5) - Unnecessary use of Custom AppBar #6
Merged
danascape
merged 8 commits into
danascape:master
from
rajitdeb:fix-unnecessary-custom-app-bar
Oct 25, 2023
Merged
Fixed issue (#5) - Unnecessary use of Custom AppBar #6
danascape
merged 8 commits into
danascape:master
from
rajitdeb:fix-unnecessary-custom-app-bar
Oct 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ainActivity. Also did some code sanitization and cleanup
…ainActivity. Also did some code sanitization and cleanup
This reverts commit 92b1e12.
DO NOT MERGE THIS PR NOW. There are issues with this PR i am working on them will soon resolve them |
Now, you can merge the PR i have pushed a resolved commit @danascape |
danascape
approved these changes
Oct 20, 2023
@rajitdeb you need to force push, it has conflicts |
rebase the branch once |
danascape
approved these changes
Oct 20, 2023
Done resolving Conflicts. Please merge @danascape |
danascape
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue (#5) - Unnecessary use of Custom AppBar. Also upgraded the dependencies to their compatible versions