Bugfix for rare 'race condition' #21
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nInvalidate and into the Nexus constructor
|
I think this is more technically correct (setting viewModelReady to false when the Nexus is first constructed (and all 'on' listeners still need to be added) and setting it to true as soon as the onReady fires. |
|
I think what would actually be best is that if one of the unbinds runs before the bind rather than unbinding it removes the function from onViewReady (but I'm not sure whether this is possible). Or rather: it might actually be a bug in Meteor, if the view is Invalidated (or Destroyed) it should never fire the onViewReady handlers, in my opinion (because quite frankly the view never became ready). What do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #20