Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

address #159 #188

Merged
merged 4 commits into from
Jun 5, 2022
Merged

address #159 #188

merged 4 commits into from
Jun 5, 2022

Conversation

daler
Copy link
Owner

@daler daler commented Jun 5, 2022

The original helpers.canonical_transcripts was not well tested (or even used much as far as I know).

@EFraim, this uses your PR #156 but I was unable to update it myself and fix the merge conflict (because understandably your master branch as diverged in the 2 yrs since you've addressed this!)

Eventually I would like to modularize this to instead have a method on the FeatureDB that finds the canonical transcript for a gene, and have the sequence part dealt with separately, e.g.,

for gene in genes_of_interest:
    transcript = db.canonical_transcript(gene)

but that will be later...

@daler daler merged commit ef3789e into v0.11 Jun 5, 2022
@daler daler deleted the issue-159 branch June 5, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant