Drop a "Content-Type" header, if any, for multipart requests #654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @marksto, this generally looks good to me. Would you mind adding a test that ensures the correct behavior so we don't inadvertently undo this change at a later time? |
|
@dakrone Totally second this! Pardon for being lazy yesterday. The investigation into this case required all the calories. 😅 This one is subtle as it has more to do with the Apache HttpClient internals rather than with the Tests are now included. |
marksto
force-pushed
the
fix-multipart-headers
branch
from
2b63846 to
243d624
Compare
marksto
changed the title
|
Thanks for fixing this @marksto! |
|
@dakrone Thanks for incorporating the fix! It would be nice to see a new release of the lib soonish. |
|
@marksto I've release 3.13.1 with this fix; thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dakrone Hi Lee!
This one is focused and straightforward.
It fixes a malformed multipart request in case if it goes with its own "content-type" header. In this case, an Apache HTTP Client's
FormBodyPartBuilderwon't be able to set a correct "content-type" header that contains the requiredboundaryvalue. This, in turn, will lead to inability to process the request properly on a server side and can usually be observed as a "400 Bad request" response status code.This patch simply filters out request headers named
"content-type"/"Content-Type"in case of a:multipartrequest.Cheers,
Mark