Component: VideoOnClick #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nathunsmitty |
|
doesn't look like |
nathanmsmith
suggested changes
Nov 27, 2018
| className={css` | ||
| position: relative; | ||
| filter: none; | ||
| -webkit-filter: grayscale(100%); |
There was a problem hiding this comment.
we don't need vendor prefixes, emotion handles that automatically
| import Pause from '@material-ui/icons/Pause' | ||
| import PlayArrow from '@material-ui/icons/PlayArrow' | ||
| import VolumeUp from '@material-ui/icons/VolumeUp' | ||
| import VolumeOff from '@material-ui/icons/VolumeOff' |
There was a problem hiding this comment.
we already use font awesome icons for most things, any chance we could use font awesome icons for these?
| @@ -0,0 +1 @@ | |||
| declare module 'video-react'; | |||
There was a problem hiding this comment.
| width: 400px; | ||
| `} | ||
| > | ||
| {this.state.video && ( |
There was a problem hiding this comment.
since we're rendering components when we both have video and not, let's use a ternary
legitmaxwu
force-pushed
the
max/video-on-hover
branch
from
b1d356b to
dd54901
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i just realized that I named this component wrong. I will change it later, or someone else can change it.
The image saturates on hover, and when the play button is clicked, the element toggles to a video which immediately starts playing! :)