[dagster-azure] Generate URL from compute log manager #26171
+70
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Nov 27, 2024
mlarose
reviewed
Nov 27, 2024
dpeng817
force-pushed
the
dpeng817/generate_url
branch
from
9edb670
to
bdb2dc3
Compare
dpeng817
commented
Nov 27, 2024
...ion_tests/test_suites/dagster-azure-live-tests/integration_tests/test_compute_log_manager.py
Show resolved
Hide resolved
dpeng817
force-pushed
the
dpeng817/azure_computelogmanager_tests
branch
from
ea77c4b
to
f4b793c
Compare
dpeng817
force-pushed
the
dpeng817/generate_url
branch
from
bdb2dc3
to
4bdfc9c
Compare
This was referenced Nov 27, 2024
mlarose
approved these changes
Nov 29, 2024
...ion_tests/test_suites/dagster-azure-live-tests/integration_tests/test_compute_log_manager.py
Show resolved
Hide resolved
| @@ -78,7 +78,9 @@ def __init__( | |||
| prefix="dagster", | |||
| upload_interval=None, | |||
| default_azure_credential=None, | |||
| show_url_only=True, | |||
There was a problem hiding this comment.
update doc string to mention the show_url_only parameter
prha
approved these changes
Dec 3, 2024
dpeng817
force-pushed
the
dpeng817/azure_computelogmanager_tests
branch
from
f4b793c
to
3449d97
Compare
dpeng817
force-pushed
the
dpeng817/generate_url
branch
from
4bdfc9c
to
852b151
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
+71
to
+72
| assert stdout.count("Printing without context") == 10 | ||
| assert stderr.count("Logging using context") == 10 |
There was a problem hiding this comment.
The stdout/stderr assertions are reversed from the original test. The original test expects stdout to contain "Logging using context" and stderr to contain "Printing without context". The current assertions have these swapped. This should be:
assert stdout.count("Logging using context") == 10
assert stderr.count("Printing without context") == 10Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
See comments for additional context.
This PR changes the Azure compute log manager to generate a URL by default instead of capturing the logs.
There's a few considerations here:
How I Tested These Changes
Switches the tests to pull out the stdout/stderr urls and read the results.