[9/n] [RFC] Implement updated designs: Sensor result page [3/N] #26153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dliu27
commented
Nov 26, 2024
There was a problem hiding this comment.
we use this dialog other places too, so added optional props for Open in Launchpad button to work
|
Deploy preview for dagit-storybook ready! ✅ Preview Built with commit 074b102. |
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 074b102. |
salazarm
reviewed
Dec 2, 2024
js_modules/dagster-ui/packages/ui-core/src/ticks/DryRunRequestTable.tsx
Outdated
Show resolved
Hide resolved
salazarm
reviewed
Dec 2, 2024
js_modules/dagster-ui/packages/ui-core/src/ticks/SensorDryRunDialog.tsx
Outdated
Show resolved
Hide resolved
salazarm
reviewed
Dec 2, 2024
js_modules/dagster-ui/packages/ui-core/src/ticks/SensorDryRunDialog.tsx
Outdated
Show resolved
Hide resolved
salazarm
reviewed
Dec 3, 2024
js_modules/dagster-ui/packages/ui-components/src/components/NonIdealState.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Linear: https://linear.app/dagster-labs/issue/FE-699/implement-updated-designs-sensor-result-page-[3n]
Implement design for sensor result page
Video:
Recording.at.2024-11-26.17.21.30.mp4
Timeout:
How I Tested These Changes
jest, tested locally with all the flows in the video
Changelog