adding onChangePartsData event #43
Open
+73
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…from defaultPartsData
…>' but required in type 'PartData'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proposed event is useful when you need to get more data than the name and id of the mentions or any partType that the trigger property sets.
In my case I needed to save the mentions in a separate field in the database for query purposes. He also needed to get other information from the mentioned user. This implementation allows handling this case simply by listening to the onChangePartsData event, it also allows passing a default value or initial value which is useful in case you want to modify the value previously generated by a MentionInput.
The new implementation does not affect the existing behavior of the package and was tested in a separate project as I was unable to implement the render tests in this package.