-
Notifications
You must be signed in to change notification settings - Fork 0
Api and component documentation #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: crfirey <[email protected]>
|
Cursor Agent can help with this pull request. Just |
Summary of ChangesHello @cyserman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request establishes the foundational documentation structure for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request does a good job of setting up documentation stubs for the project's public API and usage instructions. The templates are well-structured and will be helpful as the project grows. I've identified a few minor areas for improvement in the documentation text to enhance clarity and correct a typo. My feedback includes suggestions for the README.md and docs/PUBLIC_API.md files.
| @@ -1,2 +1,10 @@ | |||
| # ProSe | |||
|
|
|||
| the main module for Prose' litagints | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There appear to be a couple of typos in the project description. "Prose'" seems to be a typo for the project name "ProSe", and "litagints" is likely a misspelling. Could you please clarify what was intended? I've suggested a possible correction below.
| the main module for Prose' litagints | |
| the main module for ProSe agents |
| @@ -0,0 +1,72 @@ | |||
| # Public API Documentation (Auto-generated) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The title includes "(Auto-generated)", which could be misleading as this file appears to be a manually created template. To avoid potential confusion for future contributors, I recommend removing this part of the title.
| # Public API Documentation (Auto-generated) | |
| # Public API Documentation |
| - Documented commit scope: `README.md` only | ||
| - Public surface discovered: **none** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The term "Documented commit scope" is not standard and might be confusing. The following line, "Public surface discovered: none", already conveys that there are no APIs yet. To improve clarity, I suggest removing the line about the commit scope.
| - Documented commit scope: `README.md` only | |
| - Public surface discovered: **none** | |
| - Public surface discovered: **none** |
Add documentation stubs for public APIs and usage, and update README to reflect the current lack of source code.