-
Couldn't load subscription status.
- Fork 3.4k
chore (draft): refactor server files to TypeScript #32838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AtofStryker
wants to merge
3
commits into
develop
Choose a base branch
from
chore/refactor_server_p2
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
chore/refactor_server_p2
|
| Run status |
|
| Run duration | 43m 19s |
| Commit |
|
| Committer | Bill Glesias |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
1
|
|
|
10
|
|
|
1102
|
|
|
4
|
|
|
26625
|
| View all changes introduced in this branch ↗︎ | |
Warning
Partial Report: The results for the Application Quality reports may be incomplete.
UI Coverage
45.48%
|
|
|---|---|
|
|
188
|
|
|
161
|
Accessibility
97.98%
|
|
|---|---|
|
|
4 critical
8 serious
2 moderate
2 minor
|
|
|
101
|
Tests for review
cypress/e2e/commands/files.cy.js • 1 failed test • 5x-driver-firefox
dc5b886 to
18c1405
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?Note
Migrates server utilities and file server to TypeScript, updates random/env APIs and imports, integrates typed file server/HTTPS proxy, and adjusts tests accordingly.
file_server,util/env, andutil/terminal-sizefrom JS to TS; add typings forFileServerand HTTPS proxyServer.util/fileto TSFileclass with typed methods andnoopFile; update call sites (cache.ts,saved_state.ts, tests) to import{ File as FileUtil }.envimport with* as env; inutil/resolve.jsuseprocess.envdirectly.randomhelper to namedidexport and update usages across server (modes,run,cloud/auth, etc.).https-proxy/lib/index.ts, re-exporttype { Server }.server-base.tsto import* as fileServer, type cast_httpsProxyand_fileServer, and passfileServerFolderasstring.x-cypress-file-server-errorto'true', add@ts-expect-errornotes).print-run.beginUploadActivityOutputviaNumber(UPLOAD_ACTIVITY_INTERVAL).Fileexport; adjust random ID tests to userandomId.Written by Cursor Bugbot for commit 18c1405. This will update automatically on new commits. Configure here.