-
Couldn't load subscription status.
- Fork 3.4k
feat: display self healed badge for cy.prompt #32802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
…com:cypress-io/cypress into alejandro/chore/implement-self-healed-badge
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
alejandro/chore/implement-self-healed-badge
|
| Run status |
|
| Run duration | 19m 45s |
| Commit |
|
| Committer | Jennifer Shehane |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
12
|
|
|
408
|
|
|
4
|
|
|
26630
|
| View all changes introduced in this branch ↗︎ | |
Warning
Partial Report: The results for the Application Quality reports may be incomplete.
UI Coverage
45.61%
|
|
|---|---|
|
|
187
|
|
|
161
|
Accessibility
97.98%
|
|
|---|---|
|
|
4 critical
8 serious
2 moderate
2 minor
|
|
|
101
|
…com:cypress-io/cypress into alejandro/chore/implement-self-healed-badge
…com:cypress-io/cypress into alejandro/chore/implement-self-healed-badge
…com:cypress-io/cypress into alejandro/chore/implement-self-healed-badge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some notes from the bot here.
| @@ -0,0 +1,14 @@ | |||
| import React from 'react' | |||
| import SparkleIcon from '@packages/frontend-shared/src/assets/icons/sparkle_x16.svg' | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@estrada9166 Was this not working with the @cypress-design/react-icon package?
|
|
||
| get isSelfHealed () { | ||
| return this._isSelfHealed | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@estrada9166 Can you test this?
|
|
||
| get isSelfHealed () { | ||
| return (!!this.renderProps.selfHealed || (this.hasChildren && !this.isOpen && this.children.some((child) => !!child.renderProps.selfHealed))) | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
|
||
| get isSelfHealed () { | ||
| return (!!this.renderProps.selfHealed || (this.hasChildren && !this.isOpen && this.children.some((child) => !!child.renderProps.selfHealed))) | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
|
||
| **Features:** | ||
|
|
||
| - Added a 'Self-healed' badge to the Command Log when `cy.prompt()` steps automatically recover after the element they need is not found in the cache. Addressed in [#32802](https://github.com/cypress-io/cypress/pull/32802). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@estrada9166 You'll need to put a changelog entry with proper semver for every prompt feature since this is publicly released now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to work fine. Would like some feedback from design around the hovering styles.
…com:cypress-io/cypress into alejandro/chore/implement-self-healed-badge
Additional details
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?Note
Adds a styled Self-healed badge, rendering on self-healed commands and at the test level when any attempt contains a self-healed command, with tests and changelog updates.
SelfHealedBadgecomponent (src/lib/selfHealedBadge.tsx,selfHealedBadge.scss) and imports into main styles; displays next to command messages and test titles.renderProps.selfHealedand computedisSelfHealedtoCommandModelandTestModelto surface badge state across nested/collapsed groups and attempts.commands/command.tsxandtest/test.tsx; adjusts message spacing incommands.scss.cypress/e2e/commands.cy.ts).#isSelfHealedtests forTestModelacross retries (cypress/e2e/unit/test_model.cy.ts).cli/CHANGELOG.md).Written by Cursor Bugbot for commit d76e131. This will update automatically on new commits. Configure here.