-
Notifications
You must be signed in to change notification settings - Fork 3.3k
dependency: [email protected] (WIP) #31912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cacieprins
wants to merge
53
commits into
release/15.0.0
Choose a base branch
from
electron-36
base: release/15.0.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto electron-34
cypress
|
Project |
cypress
|
Branch Review |
electron-36
|
Run status |
|
Run duration | 20m 24s |
Commit |
|
Committer | Cacie Prins |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
3
|
|
2
|
|
27
|
|
0
|
|
766
|
View all changes introduced in this branch ↗︎ |
UI Coverage
62.34%
|
|
---|---|
|
27
|
|
48
|
Accessibility
96.18%
|
|
---|---|
|
0 critical
4 serious
1 moderate
0 minor
|
|
119
|
Tests for review
cypress\e2e\runner\ui-states.cy.ts • 2 failed tests • app-e2e
Test | Artifacts | |
---|---|---|
src/cypress/runner ui states > status codes |
Test Replay
Screenshots
|
|
src/cypress/runner ui states > errors > long error |
Test Replay
Screenshots
|
cypress\e2e\studio\studio.cy.ts • 1 failed test • app-e2e
Test | Artifacts | |
---|---|---|
Cypress Studio > does not create a new test if the Save test modal is closed |
Test Replay
Screenshots
|
cypress\e2e\choose-a-browser.cy.ts • 1 flaky test • launchpad-e2e
Test | Artifacts | |
---|---|---|
Choose a browser page > System Browsers Detected > launches when --browser is passed alone through the command line |
Test Replay
Screenshots
|
cypress\e2e\studio\studio.cy.ts • 1 flaky test • app-e2e
Test | Artifacts | |
---|---|---|
Cypress Studio > removes the studio url parameters when saving a new test |
Test Replay
Screenshots
|
* use node 22 in the v8 snapshot update workflow * index on windows-v8-snapshots: a013464 use node 22 in the v8 snapshot update workflow * index on windows-v8-snapshots: a013464 use node 22 in the v8 snapshot update workflow * index on windows-v8-snapshots: a013464 use node 22 in the v8 snapshot update workflow * run workflows on windows/mac --------- Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com>
… the code frame. Accounts additionally for node:diagnostics_channel (#31935)
* update the fs.readFileSync integrity check expectation * maybe this fn is missing from the expected stack? * more debug, change the stack up a little * actual fn name is traceSync * logging * logging * remove logging from integrity check * maybe circle api changed? * correct params * inspect stack frames for differences * have to manually serialize the stack frames * change expectation * update expected global keys * additional allow list * update key allow list * increase zipfile size limit on non-windows builds * revert logging changes * Update scripts/binary/binary-integrity-check-source.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?