Skip to content

dependency: [email protected] (WIP) #31912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 53 commits into
base: release/15.0.0
Choose a base branch
from
Open

Conversation

cacieprins
Copy link
Contributor

@cacieprins cacieprins commented Jun 18, 2025

Additional details

Steps to test

How has the user experience changed?

PR Tasks

@cacieprins cacieprins changed the title Dependency: Electron 36 (WIP) dependency: [email protected] Jun 18, 2025
@cacieprins cacieprins marked this pull request as ready for review June 18, 2025 15:24
@cacieprins cacieprins changed the title dependency: [email protected] dependency: [email protected] (WIP) Jun 18, 2025
Copy link

cypress bot commented Jun 18, 2025

cypress    Run #63348

Run Properties:  status check failed Failed #63348  •  git commit 8d2356912b: Fixes electron 36 integrity checks (#31956)
Project cypress
Branch Review electron-36
Run status status check failed Failed #63348
Run duration 20m 24s
Commit git commit 8d2356912b: Fixes electron 36 integrity checks (#31956)
Committer Cacie Prins
View all properties for this run ↗︎

Test results
Tests that failed  Failures 3
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 27
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 766
View all changes introduced in this branch ↗︎
UI Coverage  62.34%
  Untested elements 27  
  Tested elements 48  
Accessibility  96.18%
  Failed rules  0 critical   4 serious   1 moderate   0 minor
  Failed elements 119  

Tests for review

Failed  cypress\e2e\runner\ui-states.cy.ts • 2 failed tests • app-e2e

View Output

Test Artifacts
src/cypress/runner ui states > status codes Test Replay Screenshots
src/cypress/runner ui states > errors > long error Test Replay Screenshots
Failed  cypress\e2e\studio\studio.cy.ts • 1 failed test • app-e2e

View Output

Test Artifacts
Cypress Studio > does not create a new test if the Save test modal is closed Test Replay Screenshots
Flakiness  cypress\e2e\choose-a-browser.cy.ts • 1 flaky test • launchpad-e2e

View Output

Test Artifacts
Choose a browser page > System Browsers Detected > launches when --browser is passed alone through the command line Test Replay Screenshots
Flakiness  cypress\e2e\studio\studio.cy.ts • 1 flaky test • app-e2e

View Output

Test Artifacts
Cypress Studio > removes the studio url parameters when saving a new test Test Replay Screenshots

* use node 22 in the v8 snapshot update workflow

* index on windows-v8-snapshots: a013464 use node 22 in the v8 snapshot update workflow

* index on windows-v8-snapshots: a013464 use node 22 in the v8 snapshot update workflow

* index on windows-v8-snapshots: a013464 use node 22 in the v8 snapshot update workflow

* run workflows on windows/mac

---------

Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com>
cacieprins and others added 5 commits June 23, 2025 12:12
… the code frame. Accounts additionally for node:diagnostics_channel (#31935)
* update the fs.readFileSync integrity check expectation

* maybe this fn is missing from the expected stack?

* more debug, change the stack up a little

* actual fn name is traceSync

* logging

* logging

* remove logging from integrity check

* maybe circle api changed?

* correct params

* inspect stack frames for differences

* have to manually serialize the stack frames

* change expectation

* update expected global keys

* additional allow list

* update key allow list

* increase zipfile size limit on non-windows builds

* revert logging changes

* Update scripts/binary/binary-integrity-check-source.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants